Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-456] chore: display sub issues option added in global view issues #3712

Merged
merged 3 commits into from
Feb 21, 2024
Merged

[WEB-456] chore: display sub issues option added in global view issues #3712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a8e1a7
chore: ensure global view issues displays sub-issues by default
anmolsinghbhatia Feb 20, 2024
13ae833
chore: sub issue toggle option added in global view issues
anmolsinghbhatia Feb 20, 2024
f8b1467
Merge branch 'develop' of github.com:makeplane/plane into chore/globa…
anmolsinghbhatia Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web/constants/issue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,8 @@ export const ISSUE_DISPLAY_FILTERS_BY_LAYOUT: {
type: [null, "active", "backlog"],
},
extra_options: {
access: false,
values: [],
access: true,
values: ["sub_issue"],
},
},
list: {
Expand Down Expand Up @@ -449,4 +449,4 @@ export const groupReactionEmojis = (reactions: any) => {
}

return _groupedEmojis;
};
};
7 changes: 0 additions & 7 deletions web/store/issue/workspace/filter.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ export class WorkspaceIssuesFilter extends IssueFilterHelperStore implements IWo
filteredParams
);

if (userFilters?.displayFilters?.layout === "spreadsheet") filteredRouteParams.sub_issue = false;

return filteredRouteParams;
};

Expand Down Expand Up @@ -213,11 +211,6 @@ export class WorkspaceIssuesFilter extends IssueFilterHelperStore implements IWo
_filters.displayFilters.group_by = "state";
updatedDisplayFilters.group_by = "state";
}
// set sub_issue to false if layout is switched to spreadsheet and sub_issue is true
if (_filters.displayFilters.layout === "spreadsheet" && _filters.displayFilters.sub_issue === true) {
pushya22 marked this conversation as resolved.
Show resolved Hide resolved
_filters.displayFilters.sub_issue = false;
updatedDisplayFilters.sub_issue = false;
}

runInAction(() => {
Object.keys(updatedDisplayFilters).forEach((_key) => {
Expand Down
Loading