Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: active cycle issue transfer validation #3560

Merged
merged 7 commits into from
Feb 5, 2024
Merged

chore: active cycle issue transfer validation #3560

merged 7 commits into from
Feb 5, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

Problem

  1. Users currently have the ability to edit issues from the layout, create issues from the group header, and perform various actions through the quick add issue feature even after the cycle is completed. Ideally, when a cycle is completed, issues should not be editable.
  2. Users with guest and viewer roles can access quick action menu actions in certain places, which is unintended behavior.

Resolution

  1. The problem has been addressed by implementing the required validations to restrict issue editing after the completion of a cycle.
  2. Necessary validations have been added to prevent users with guest and viewer roles from accessing quick action menu actions in inappropriate places.

Additional Fixes and Improvements

  • Fixed the disabled state issue in the date dropdown.

@sriramveeraghanta sriramveeraghanta merged commit ee0e3e2 into develop Feb 5, 2024
6 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/active-cycle-issue-transfer-validation branch February 5, 2024 09:17
@srinivaspendem srinivaspendem modified the milestones: v0.15.1-dev, v0.16 Feb 6, 2024
NarayanBavisetti added a commit that referenced this pull request May 8, 2024
@sriramveeraghanta @anmolsinghbhatia
@rameshkumarchandra @rahulramesha @pablohashescobar @1akhanBaheti @aaryan610 @NarayanBavisetti @mguptahub @jlucaso1 @Palanikannan1437
Merge pull request #113 from makeplane/preview
2dc7cae 
* chore: breadcrumb component improvement (#3537)

* chore: breadcrumb component improvement

* chore: code refactor

* fix: create issue modal project select (#3549)

* chore: responsive and styling fixes (#3541)

* fix: all issues spreadsheet sorting and kanban dnd for long lists (#3550)

* fix all issues filter for spreadsheet view

* fix kanban dnd with long lists

* dev: validation for external id and external source (#3552)

* dev: error response for duplicate items created through external apis

* dev: return identifier and also add the validation for state

* fix: validation for external id and external source

* chore: cycle and module sidebar analytics improvement (#3559)

* chore: cycle and module store update action updated

* chore: cycle and module issue store actions updated

* chore: cycle and module retrieve endpoints updated

* fix: app sidebar z index and priority icon fix

* chore: cycle and module sidebar and stats updated

* chore: posthog events improved (#3554)

* chore: events naming convention changed

* chore: track element added for project related events

* chore: track element added for cycle related events

* chore: track element added for module related events

* chore: issue related events updated

* refactor: event tracker store

* refactor: event-tracker store

* fix: posthog changes

---------

Co-authored-by: sriram veeraghanta <[email protected]>

* fix: build fixes

* fix: sentry error fixes

* chore: active cycle issue transfer validation (#3560)

* fix: completed cycle list layout validation

* fix: completed cycle kanban layout validation

* fix: completed cycle spreadsheet layout validation

* fix: date dropdown disabled fix

* chore: quick action validation added for list, kanban and spreadsheet layout

* fix: calendar layout validation added

* fix: useberry script added

* chore: added `None` filter option to the dashboard widgets (#3556)

* chore: added tab change animation

* chore: widgets filtering logic updated

* refactor: issues list widget

* fix: tab navigation transition

* fix: extra top spacing on opening the peek overview

* chore: removed email notification for new users (#3561)

* chore: cycle and module sidebar improvement (#3562)

* chore: module date validation (#3565)

* app_release value handled (#3571)

* chore: email trigger for new assignee (#3572)

* dev: update the response for conflicting errors (#3568)

* style: responsive breadcrumbs and headers for dashboard, projects, project issues, cycles, cycle issues, module issues (#3580)

* fix: dashboard header z index and workspace active cycles fix (#3581)

* fix: dashboard header z index fix

* chore: workspace active cycles upgrade page improvement

* fix: draft issue peek overview (#3582)

* chore: project, view and shortcut modal alignment consistency

* chore: issue highlight list layout improvement

* fix: draft issue peek overview fix

* fix: draft issue layout inline editing

* chore: module issue count (#3566)

* chore: mention notification and webhook faliure (#3573)

* fix: mention rstrip error

* chore: webhook deactivation email

* chore: changed template

* chore: current site for external api's

* chore: mention in template displayed

* chore: mention tag fix

* chore: comment user name displayed

* dev: create fake data for issues (#104)

* dev: create fake data for issues

* dev: remove endpoint

* dev: update faker script

* chore: workspace dashboard refactor (#3584)

* fix: faker import (#111)

* fix: show window closing alert only when page is not saved (#3577)

* fix: show window closing alert only when page is not saved

* chore: Refactor useReloadConfirmations hook

- Removed the `message` parameter, as it was not being used and not
  supported in modern browsers
- Changed the `isActive` flag to a temporary flag and added a TODO comment to remove it later.
- Implemented the `handleRouteChangeStart` function to handle route change events and prompt the user with a confirmation dialog before leaving the page.
- Updated the dependencies of the `handleBeforeUnload` and `handleRouteChangeStart` callbacks.
- Added event listeners for `beforeunload` and `routeChangeStart` events in the `useEffect` hook.
- Cleaned up the event listeners in the cleanup function of the `useEffect` hook.

fix: Fix reload confirmations in PageDetailsPage

- Removed the TODO comment regarding fixing reload confirmations with MobX, as it has been resolved.
- Passed the `pageStore?.isSubmitting === "submitting"` flag to the `useReloadConfirmations` hook instead of an undefined message.

This commit refactors the `useReloadConfirmations` hook to improve its functionality and fixes the usage in the `PageDetailsPage` component.

---------

Co-authored-by: Palanikannan1437 <[email protected]>

* chore: posthog code refactor (#3586)

* dev: update faker script to take inputs (#112)

* dev: update faker script to take inputs

* dev: update while check

---------

Co-authored-by: Anmol Singh Bhatia <[email protected]>
Co-authored-by: Ramesh Kumar Chandra <[email protected]>
Co-authored-by: rahulramesha <[email protected]>
Co-authored-by: Nikhil <[email protected]>
Co-authored-by: Lakhan Baheti <[email protected]>
Co-authored-by: Aaryan Khandelwal <[email protected]>
Co-authored-by: Bavisetti Narayan <[email protected]>
Co-authored-by: Manish Gupta <[email protected]>
Co-authored-by: João Lucas de Oliveira Lopes <[email protected]>
Co-authored-by: Palanikannan1437 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees
No one assigned
Labels
🐛bug Something isn't working 🧹chore 🌐frontend 🌟improvement
Projects
None yet
Milestone
v0.16-dev
Development

Successfully merging this pull request may close these issues.
3 participants
@anmolsinghbhatia @sriramveeraghanta @srinivaspendem