fix: Adding back enter key extension with mentions #3499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added back the enter key extension at #2530, but this time working with Mentions
Comment Editor's Features
The enter key is now remapped to submit the comment, while the 'shift-enter' key is mapped to the default enter key behavior. The edge cases for the various data structures/scenarios present in the comment editor have been handled as follows:
End of Blocks: When the cursor is at the end of a block, "Shift-Enter" creates a new paragraph below the current block.
Here's a sleek demo video showcasing these changes (note I'm using Shift + Enter here as Enter key defaults to Submitting the comment itself)
Export-1698477557840.mp4
The enter extension works properly now with mentions as we're keeping track of whether the mentions menu is open or not via a custom storage object in the extension and then using that modify the enter key extensions's behaviour.
Screen.Recording.2024-01-31.at.6.27.22.PM.mov