Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: empty state revamp and loader improvement #3448

Merged
merged 16 commits into from
Jan 24, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Jan 24, 2024

This PR includes revamp of the empty state, featuring conditional rendering of content, dynamic theme implementation, a customised comic box to retrieve button action details, and responsive design enhancements. [PLE-243]

Additionally, I have addressed the empty state flicker issue during the loading cycle of modules, views, and pages. I resolved this by adding a loader in the store while fetching data to display a loading spinner.

Media

Light Mode: Dark Mode:
l-1 d-1
l-1-1 d-1-1
l-2 d-2
l-3 d-3
l-4 d-4
l-5 d-5
l-6 d-6
l-7 d-7
l-8 d-8
I-9 d-9
I-10 d-10
I-11 d-11

@anmolsinghbhatia anmolsinghbhatia changed the title chore: empty state revamp chore: empty state revamp and loader improvement Jan 24, 2024
image: EmptyStateImagePath,
primaryButton: {
text: "Set Automation",
onClick: () => router.push(`/${workspaceSlug}/projects/${projectId}/settings/automations`),

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
@sriramveeraghanta sriramveeraghanta merged commit 87f39d7 into develop Jan 24, 2024
6 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/empty-state-and-loader-improvement branch January 24, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants