-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: empty state revamp and loader improvement #3448
Merged
sriramveeraghanta
merged 16 commits into
develop
from
chore/empty-state-and-loader-improvement
Jan 24, 2024
Merged
chore: empty state revamp and loader improvement #3448
sriramveeraghanta
merged 16 commits into
develop
from
chore/empty-state-and-loader-improvement
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-state-and-loader-improvement
anmolsinghbhatia
changed the title
chore: empty state revamp
chore: empty state revamp and loader improvement
Jan 24, 2024
sriramveeraghanta
requested changes
Jan 24, 2024
web/components/issues/issue-layouts/empty-states/archived-issues.tsx
Outdated
Show resolved
Hide resolved
…-state-and-loader-improvement
image: EmptyStateImagePath, | ||
primaryButton: { | ||
text: "Set Automation", | ||
onClick: () => router.push(`/${workspaceSlug}/projects/${projectId}/settings/automations`), |
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
Untrusted URL redirection depends on a .
user-provided value
Error loading related location
Loading
sriramveeraghanta
approved these changes
Jan 24, 2024
…-state-and-loader-improvement
sriramveeraghanta
deleted the
chore/empty-state-and-loader-improvement
branch
January 24, 2024 13:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes revamp of the empty state, featuring conditional rendering of content, dynamic theme implementation, a customised comic box to retrieve button action details, and responsive design enhancements. [PLE-243]
Additionally, I have addressed the empty state flicker issue during the loading cycle of modules, views, and pages. I resolved this by adding a loader in the store while fetching data to display a loading spinner.
Media