chore: UI/UX improvements #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut isn't active yet.
…imates empty state.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| image={emptyIntegration} | ||
| primaryButton={{ | ||
| text: "Configure now", | ||
| onClick: () => router.push(`/${workspaceSlug}/settings/integrations`), |
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
sriramveeraghanta
approved these changes
Jan 5, 2024
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jan 22, 2024
* chore: add proper message for cycle/ module having start & end date but isn't active yet. * fix: infinite loader after updating workspace settings. * fix: user profile icon dropdown doesn't closes automatically. * style: fix inconsistent padding in cycle empty state. * chore: remove multiple `empty state` in labels settings and improve add label logic. * style: fix inconsistent padding in project label, integration and estimates empty state. * style: fix integrations settings breadcrumb title. * style: add proper `disabled` styles for email field in profile settings. * style: fix cycle layout height.
sriramveeraghanta
pushed a commit
that referenced
this pull request
Jan 22, 2024
* chore: add proper message for cycle/ module having start & end date but isn't active yet. * fix: infinite loader after updating workspace settings. * fix: user profile icon dropdown doesn't closes automatically. * style: fix inconsistent padding in cycle empty state. * chore: remove multiple `empty state` in labels settings and improve add label logic. * style: fix inconsistent padding in project label, integration and estimates empty state. * style: fix integrations settings breadcrumb title. * style: add proper `disabled` styles for email field in profile settings. * style: fix cycle layout height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several UI/UX issue in the platform.
Problems Fixed
1. Progress chart error message is incorrect for cycle/ module that are not active yet.
The upcoming Cycles/Modules still display
Invalid Datedespite having start and end dates specified.Solution
Updated it to
This cycle/module isn't active yet.2. After updating the workspace from workspace settings. The loader isn’t stopping.
The issue occured because we updated the global state with incomplete
form data, lacking crucial fields like theworkspace slug. Consequently, thecurrentWorkspaceremained null as we couldn't filter its details without the necessaryslugin the global state.Solution
Updated the
updateWorkspaceaction to use response data which contains the complete object.workspace_update.1.mp4
3. In user profile settings, the email field should have
cursor-not-allowedstyle.The email field cannot be edited, but its appearance lacks any distinguishing style, making it seem editable.
Solution
Added proper
Disabledstyle to it.4. User profile icon dropdown doesn't closes automatically.
The dropdown for the Profile icon in the sidebar header doesn't close when any menu item is clicked.
Solution
user_dropdown.1.mp4
5. Inconsistent padding in Cycle empty state.
Solution
cycle_padding.1.mp4
6. Project labels empty state showing two times. Also, empty state should be removed if I click on add label.
7. Inconsistent padding in Labels, Integration, Estimates settings empty state.
Solution
labels.1.mp4
8. Workspace Integration setting breadcrumb shows
Export Settings.Solution