Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env substitute issue in websocket docker setup #3296

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Fix env substitute issue in websocket docker setup #3296

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8cbfa18
fix websocket connection issue in docker makeplane/plane#3195
abidkhan484 Dec 19, 2023
a4fcd22
fix websocket connection issue for local env with removing from the p…
abidkhan484 Dec 20, 2023
ac63624
Merge branch 'preview' into fix-websocket-docker-setup
abidkhan484 Dec 20, 2023
2123621
Merge branch 'preview' into fix-websocket-docker-setup
abidkhan484 Jan 1, 2024
9690387
fix env substitution issue of proxy_set_header makeplane/plane#3196
abidkhan484 Jan 1, 2024
c673353
review fixes
mguptahub Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nginx/nginx.conf.dev
View file
Open in desktop
abidkhan484 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ http {
location / {
proxy_pass http://web:3000/;
proxy_http_version 1.1;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Upgrade $${empty}http_upgrade;
proxy_set_header Connection "upgrade";
}

Expand Down
Loading