Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: gpt modal refactor #3276

Merged
merged 4 commits into from
Jan 2, 2024
Merged

chore: gpt modal refactor #3276

merged 4 commits into from
Jan 2, 2024

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Dec 29, 2023 •
edited
Loading

This PR involves a restructuring of the GPT assistant modal. Here are the key changes:

  • Ensuring uniformity in the user interface across the draft, inbox, and issue form.
  • Transitioning the current GPT assistant modal to a popover component with following props:
  • Introduction of the following properties:
    • isOpen
    • projectId
    • handleClose
    • onResponse
    • button
    • onError (optional)
    • prompt (optional)
    • placement (optional)
    • className (optional)

This issue is connected to the issue [PLE-57]

@anmolsinghbhatia anmolsinghbhatia added this to the v0.15-dev milestone Dec 29, 2023
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review December 29, 2023 07:31
@sriramveeraghanta sriramveeraghanta marked this pull request as draft December 29, 2023 11:04
@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review January 1, 2024 08:06
@sriramveeraghanta sriramveeraghanta merged commit d9ee692 into develop Jan 2, 2024
6 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/gpt_modal_refactor branch January 2, 2024 07:37
sriramveeraghanta pushed a commit that referenced this pull request Jan 22, 2024
@anmolsinghbhatia @sriramveeraghanta
chore: gpt modal refactor (#3276)
f0bb3db 
* chore: gpt modal refactor

* chore: refactored gpt assistant modal to popover component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees
No one assigned
Labels
🧹chore 🌐frontend 🛠️refactor
Projects
None yet
Milestone
v0.15-dev
Development

Successfully merging this pull request may close these issues.
2 participants
@anmolsinghbhatia @sriramveeraghanta