Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unnecessary overflow in the profile settings layout #3163

Merged
merged 1 commit into from
Dec 16, 2023
Merged

fix: unnecessary overflow in the profile settings layout #3163

merged 1 commit into from
Dec 16, 2023

Conversation

aaryan610
Copy link
Collaborator

@aaryan610 aaryan610 commented Dec 15, 2023 •
edited
Loading

Problem:

  1. Profile settings pages have an unnecessary scroll even if the content occupies less height than the screen.

Solution:

  1. Replaced margin-top of the container with padding-top.

Media:

Before fix-

Screen.Recording.2023-12-16.at.2.19.14.AM.mov

@aaryan610 aaryan610 added this to the 0.14.1-dev milestone Dec 15, 2023
@sriramveeraghanta sriramveeraghanta merged commit e590215 into develop Dec 16, 2023
7 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/profile_layout branch December 16, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees
No one assigned
Labels
🌐frontend 🎨UI / UX
Projects
None yet
Milestone
0.14.1-dev
Development

Successfully merging this pull request may close these issues.
2 participants
@aaryan610 @sriramveeraghanta