Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: made project-identifier rule consistent #3148

Merged
merged 1 commit into from
Dec 16, 2023
Merged

chore: made project-identifier rule consistent #3148

merged 1 commit into from
Dec 16, 2023

Conversation

1akhanBaheti
Copy link
Collaborator

@1akhanBaheti 1akhanBaheti commented Dec 15, 2023 •
edited
Loading

This PR Fixes #2139

Problem:

  • Project identifier rules are not consistent in the platform, somewhere shows 12 somewhere 5 characters limit.

Solution:

  • Made it consistent with at most 6 characters long.

Before:

image

After:

image

image

@1akhanBaheti 1akhanBaheti added 🐛bug Something isn't working 🎨UI / UX labels Dec 15, 2023
@1akhanBaheti 1akhanBaheti added this to the 0.14.1-dev milestone Dec 15, 2023
@1akhanBaheti 1akhanBaheti self-assigned this Dec 15, 2023
@1akhanBaheti 1akhanBaheti linked an issue Dec 15, 2023 that may be closed by this pull request
[bug]: Project identifier rules are misleading #2139
Closed
1 task
@1akhanBaheti 1akhanBaheti marked this pull request as ready for review December 15, 2023 11:04
@sriramveeraghanta sriramveeraghanta merged commit a37dec4 into develop Dec 16, 2023
7 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/project-identifier branch December 16, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@aaryan610 aaryan610 Awaiting requested review from aaryan610

Assignees

@1akhanBaheti 1akhanBaheti

Labels
🐛bug Something isn't working 🎨UI / UX
Projects
None yet
Milestone
0.14.1-dev
Development

Successfully merging this pull request may close these issues.

[bug]: Project identifier rules are misleading
2 participants
@1akhanBaheti @sriramveeraghanta