Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: filter edit operation in views is disabled for lower roles #3113

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

1akhanBaheti
Copy link
Collaborator

@1akhanBaheti 1akhanBaheti commented Dec 13, 2023

Problem:

  • In views detail Viewer/Guest can manipulate filters for a fraction of seconds.

Solution:

  • Hiding the clear/clear all button in view details, and also disabled filter dropdown at the header.

Before:

image

After:

views_restriction.mp4

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
plane-dev ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:55am
plane-sh ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:55am
plane-sh-dev ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:55am
plane-sh-stage ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:55am
plane-staging ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 10:55am

@1akhanBaheti 1akhanBaheti marked this pull request as ready for review December 13, 2023 10:34
@1akhanBaheti 1akhanBaheti marked this pull request as draft December 13, 2023 10:48
@1akhanBaheti 1akhanBaheti marked this pull request as ready for review December 14, 2023 07:14
@1akhanBaheti 1akhanBaheti changed the title chore: edit/delete view options hidden for lower roles chore: filter edit operation in views is disabled for lower roles Dec 14, 2023
@1akhanBaheti 1akhanBaheti requested review from sriramveeraghanta and removed request for gurusainath December 14, 2023 10:39
@1akhanBaheti 1akhanBaheti added this to the 0.14.1-dev milestone Dec 14, 2023
@sriramveeraghanta sriramveeraghanta merged commit 4e2bf24 into develop Dec 14, 2023
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/views_access_restriction branch December 14, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants