Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spreadsheet layout sub-issues property update #3110

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

1akhanBaheti
Copy link
Collaborator

@1akhanBaheti 1akhanBaheti commented Dec 13, 2023

Problem:

  1. In the spreadsheet layout when expanding for sub-issues, the hover effect is applied to the parent issue as well.
  2. In the spreadsheet sub-issues property change is getting applied to the parent issue.

Solution:

  1. Removed the hover effect from the outer component, and moved it to the inner component.
  2. Removed default parent issue object parameter to update function, and now took the issue object from the child component.

Before:

spreadsheet_sub-issues-problem.mp4

After:

spreadsheet_sub-issues-solution.mp4

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated (UTC)
plane-dev ⬜️ Ignored (Inspect) Dec 13, 2023 9:04am
plane-sh ⬜️ Ignored (Inspect) Dec 13, 2023 9:04am
plane-sh-dev ⬜️ Ignored (Inspect) Dec 13, 2023 9:04am
plane-sh-stage ⬜️ Ignored (Inspect) Dec 13, 2023 9:04am
plane-staging ⬜️ Ignored (Inspect) Dec 13, 2023 9:04am

@1akhanBaheti 1akhanBaheti marked this pull request as ready for review December 13, 2023 09:13
@1akhanBaheti 1akhanBaheti changed the title fix: spreadsheet layout sub-issues property udpate fix: spreadsheet layout sub-issues property update Dec 13, 2023
@sriramveeraghanta sriramveeraghanta merged commit 9d0056c into develop Dec 13, 2023
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/spreadsheet_subissues branch December 13, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants