Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with peek view properties not editable and options not being shown in all workspace issues. #3100

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

prateekshourya29
Copy link
Member

@prateekshourya29 prateekshourya29 commented Dec 12, 2023

Problem:

The problem was that we didn't had details about user role for the current issue. So it was restricting us to update the issue properties. And also we are using peekProjectId in the query parameter but all the properties components were initially designed for projectId. So none of them were able to fetch data.

Solution:

  1. Used currentWorkspaceUserProjectsRole instead of currentProjectRole which was dependent on active project id.
  2. Made changes in all components in order to handle both peekProjectId and projectId.

Before fix:

before.fix.1.mp4
before.fix.2.large.mp4

After Fix:

After.fix.mp4

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
plane-dev ⬜️ Ignored (Inspect) Dec 14, 2023 2:12pm
plane-sh ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 2:12pm
plane-sh-dev ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 2:12pm
plane-sh-stage ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 2:12pm
plane-staging ⬜️ Ignored (Inspect) Dec 14, 2023 2:12pm

@aaryan610 aaryan610 marked this pull request as draft December 12, 2023 19:00
@prateekshourya29 prateekshourya29 changed the base branch from preview to develop December 14, 2023 14:13
@prateekshourya29 prateekshourya29 marked this pull request as ready for review December 14, 2023 14:14
@sriramveeraghanta sriramveeraghanta merged commit 37df0bc into develop Dec 18, 2023
6 of 8 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/all-issues-peek-view branch December 18, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working 🌐frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants