Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: issue sidebar and project view improvement and validation #3098

Merged
merged 3 commits into from
Dec 13, 2023
Merged

chore: issue sidebar and project view improvement and validation #3098

merged 3 commits into from
Dec 13, 2023

Conversation

anmolsinghbhatia
Copy link
Collaborator

@anmolsinghbhatia anmolsinghbhatia commented Dec 12, 2023 •
edited
Loading

Problem:

  • Guests and viewers have access to specific actions within the Project view:
    • Adding views from the header on the project view list page.
    • Adding issues from the header on the project view detail page.
    • Editing or deleting views from the project view list page.

Resolution:

  • Implemented validation to prevent user with guest and viewer role from accessing above mentioned action.

Other Changes

  • Issue sidebar improvement.
  • Copy view link option added in project view list item.

@anmolsinghbhatia anmolsinghbhatia added this to the 0.14.1-dev milestone Dec 12, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
plane-dev ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 0:20am
plane-sh ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 0:20am
plane-sh-dev ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 0:20am
plane-sh-stage ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 0:20am
plane-staging ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2023 0:20am

@anmolsinghbhatia anmolsinghbhatia marked this pull request as ready for review December 12, 2023 12:21
@sriramveeraghanta sriramveeraghanta merged commit fe80ca3 into develop Dec 13, 2023
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the chore/issue_sidebar_and_project_view_permission_validation branch December 13, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

Assignees
No one assigned
Labels
🌐frontend 🌟improvement
Projects
None yet
Milestone
0.14.1-dev
Development

Successfully merging this pull request may close these issues.
2 participants
@anmolsinghbhatia @sriramveeraghanta