Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cycle delete & active cycle loading #3088

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix: cycle delete & active cycle loading #3088

merged 1 commit into from
Dec 13, 2023

Conversation

1akhanBaheti
Copy link
Collaborator

@1akhanBaheti 1akhanBaheti commented Dec 12, 2023 •
edited
Loading

Problem:

  1. If there are more than 0 cycles, and no active cycle exists, then the active cycle section has infinite loading.
  2. If the active cycle gets deleted, then the UI of the active cycle section is not updated until the page is manually refreshed.

Solution:

  1. Used SWR isLoading parameter to modify the loading condition of the page.
  2. Removed the deleted cycle from the store's data also.

@1akhanBaheti 1akhanBaheti self-assigned this Dec 12, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Updated (UTC)
plane-dev ⬜️ Ignored (Inspect) Dec 12, 2023 9:20am
plane-sh ⬜️ Ignored (Inspect) Dec 12, 2023 9:20am
plane-sh-dev ⬜️ Ignored (Inspect) Dec 12, 2023 9:20am
plane-sh-stage ⬜️ Ignored (Inspect) Dec 12, 2023 9:20am
plane-staging ⬜️ Ignored (Inspect) Dec 12, 2023 9:20am

@1akhanBaheti 1akhanBaheti marked this pull request as ready for review December 12, 2023 09:59
@sriramveeraghanta sriramveeraghanta merged commit 4bb99d5 into develop Dec 13, 2023
12 of 14 checks passed
@sriramveeraghanta sriramveeraghanta deleted the fix/cycles branch December 13, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sriramveeraghanta sriramveeraghanta sriramveeraghanta approved these changes

@gurusainath gurusainath Awaiting requested review from gurusainath

@aaryan610 aaryan610 Awaiting requested review from aaryan610

Assignees

@1akhanBaheti 1akhanBaheti

Labels
🐛bug Something isn't working 🌐frontend 🎨UI / UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1akhanBaheti @sriramveeraghanta