-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cycles store #2716
Merged
Merged
refactor: cycles store #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
sriramveeraghanta
approved these changes
Nov 9, 2023
sriramveeraghanta
added a commit
that referenced
this pull request
Nov 9, 2023
* fix: package version fixes and mentions build error fixes (#2665) * fix: existing issues modal for cycle and module (#2664) * fix: existing issues modal for cycle and module * refactor: existing issues modal code * fix: build errors * dev: On Demand Code Build for any branch (#2668) * wip * wip * testing * wip * wip * wip * wip * image push fix * wip * wip * dynamic branch name and tag * workflow_dispatch modified * job splitting * file sharing * wip * checking * wip * wip * wip * wip * build fixes * code upload download fixes * image name change --------- Co-authored-by: sriram veeraghanta <[email protected]> * Fix/mentions spaces fix (#2667) * feat: add mentions store to the space project * fix: added mentions highlights in read only comment cards * feat: added mention highlights in richtexteditor in space app * fix: render the estimate select if estimate is enabled for the project (#2663) * style: updated layouts UI in the space app (#2671) * style: updated layouts UI in space * fix: build error * chore: update avatar group logic (#2672) * fix: In kanban issues can be shifted between the column in order_by (#2676) * fix: slack integration workflow (#2675) * fix: slack integration workflow * dev: add slack client id as configuration * fix: clean up * fix: added env to turbo --------- Co-authored-by: sriram veeraghanta <[email protected]> * fix: bug fixes and ui improvement (#2674) * chore: peekoverview edit permission updated * chore: tab index added in create project modal * chore: project card improvement * style: avatar component improvement * chore: create issue modal improvement * style: global style sidebar border variable name fix * style: update border across workspace and project settings. (#2669) * style: update border across workspace and project settings. * update border width * style: update project description as per design. (#2682) * fix: kanban card state name and drop down items text overflow (#2686) * fix: slack project integration (#2684) * fix: replacing jira importer image (#2685) * fix: cycle and module bug fixes and improvement (#2691) * fix: cycle and module card issue count fix * fix: cycle and module list progress icon fix * fix: module card progress fix * style: cycle & module empty date label updated * fix: build error * chore: spreadsheet layout improvement (#2677) * style: spreadsheet column width fix * style: spreadsheet label column styling * chore: spreadsheet layout issue properties improvement * fix: build error * chore: user profile issue improvement (#2679) * fix: user profile filters z-index * chore: user profile issue state group heading fix * fix: build error * chore: peek overview improvement and bug fixes (#2683) * style: issue peek overview improvement * style: peek overview improvement * fix: subscribe issue from peek overview fix and validation added * fix: build error * fix: state icon (#2678) * fix: environment config changes in the API are replicated in web and space app (#2699) * fix: envconfig type changes * chore: configuration variables (#2692) * chore: update avatar group logic (#2672) * chore: configuration variables --------- * fix: replacing slack client id with env config --------- Co-authored-by: Nikhil <[email protected]> * dev: modified the branch wise build (#2702) * cherrypicked branch build code * trigger on pull request * branch filter * checking branch filter * checking push * checking push again * code cleanup before PR * style: update font weight in project general setting section. (#2697) * dev: Modified the branch-build action yaml (#2704) * cherrypicked code * removed PUSH event * dev: worker count (#2573) * dev: workers count * dev: update the worker count variable to GUNICORN_WORKERS * style: update user profile button alignment. (#2695) * fix: add issues to cycles and modules (#2659) * fix: able to add issue in cycle and module * fix: issue activity message * fix: issue draft delete functionality (#2696) * add errors for duplicate labels (#2706) Co-authored-by: rahulramesha <[email protected]> * style: spinner component improvement (#2708) * fix: quick add not working for labels & assignee (#2689) * fix: quick add not working for labels & assignee * fix: build error on spreadsheet view * refactor: replace keyboard events with command palette store (#2688) * fix: project select validation (#2723) * Fix: Render bar chart axis labels in lighter color when dark theme applied (#2721) * fix: project automation settings flickering (#2680) * fix: cycle and module sidebar z-index * fix: project automation settings flickering * chore: remove active ids from the MobX stores if not present in the route (#2681) * chore: remove active ids if not present in the route * refactor: set active id logic * style: ui consistency and improvement (#2725) * style: create/update issue modal properties ui improvement * style: create update issue modal improvement * style: modal ui consistency * fix: bug fixes and ui improvements (#2703) * fix: gantt chart duration in decimal * fix: Loading text instead Spinner in peek view * fix: cycle more popover typo & icon overlapping * fix: list layout properties alignment * fix: project search empty state * fix: calendar layout issue text overflow & redirection inconsistency * style: urgent priority hover background color * fix: Cycle issues kanban layout empty state missing * style: custom snooze modal placeholder text color * refactor: replaced unwanted anchor tag with div * chore: removed empty state for cycle kanban layout * fix: unwanted go back button in onboarding step 2 (#2714) * fix: added empty project state when no project exists. (#2727) * fix: added empty project state when no project exists * fix: duplicate import * fix: issue property height and peek view date picker border radius (#2726) * fix: all issues values not changeable and assignee image not rendering (#2707) * fix: all issues values are not changeable and assignee image not rendering * chore: removed console log * [fix]: Error Handling for Images and Table Fix for Form Submissions in Editor (#2710) * cancellable uploads and image limits with better error handling * fixed table row/column picker behaviour on modals * Merge branch 'rerender-debounce-editor-fix' into editor-draggable-nodes * fix: added mention suggestions and highlights in `create-issue-modal` * removed uncessary files * solved lint error of trailing spaces * added plane/ui dependency for tooltips --------- Co-authored-by: Henit Chobisa <[email protected]> * style: kanban card label overflow (#2722) * chore: kanban card lable drop down items overflow * style: kaban card label text overflow, tool tip, hover cursor * style: label overflow in list layout * fix: project states fixes (#2731) * fix: project states fixes * fix: states fixes * fix: formating all files * fix: toast alert inconsistency (#2730) * fix: Tooltip content on assignee hover in all layouts (#2724) * fix: Tooltip content on assignee hover in all layouts * chore: comments added * feat: state list endpoint (#2717) * feat: state list endpoint * dev: update states endpoint * dev: mark default state endpoint * fix: workspace members store added and implemented across the app (#2732) * fix: minor changes * fix: workspace members store added and implemnted across the app * fix: cystom analytics bar graph index alignment (#2737) * fix: Add horizontal scroll bar to views (#2736) * add errors for duplicate labels * adding horizonatal scroll bar to views --------- Co-authored-by: rahulramesha <[email protected]> * style: sidebar UI improvements (#2735) * updated font weight and color as per designs. * removed background color from workspace with logo. * updated dropdown design. * fix: UI improvements. (#2734) * style: update check icon colors to match our design. * fix: automatically focus input box in pages `add label` modal. * fix: spliting out the project members from project store and service (#2739) * refactor: gantt sidebar (#2705) * refactor: gantt sidebar * fix: exception error fix: file placement * refactor: not passing sidebar block as props * chore: configuration add tracker variables (#2709) * chore: configuration add tracker variables * dev: unsplash configuration * fix: mention notification (#2670) * fix: mention notification * feat: updated mentions for comments in the notification background task * feat: added subscription for issue_comment_mentions as well * fix: removed the print statement * fix: double notification popup for mentioned assignees * fix: added issue subscriber * fix: removed creator for subscribed * fix: creator will not be subscribed to issue * fix: double notification removed --------- Co-authored-by: Henit Chobisa <[email protected]> * fix: favourite cycle and modules displayed at top (#2719) * feat: issues v2 endpoint (#2713) * feat: issue v2 listing endpoint * dev: issues v3 endpoint * dev: add permission in the grouped endpoint * dev: update grouped endpoint * fix: fliter list item clear button alignment fix (#2741) * fix: date select tooltip fix (#2740) * refactor: cycles store (#2716) * refactor: cycles store * refactor: active cycle details --------- Co-authored-by: Aaryan Khandelwal <[email protected]> Co-authored-by: Manish Gupta <[email protected]> Co-authored-by: Henit Chobisa <[email protected]> Co-authored-by: guru_sainath <[email protected]> Co-authored-by: Nikhil <[email protected]> Co-authored-by: Anmol Singh Bhatia <[email protected]> Co-authored-by: Prateek Shourya <[email protected]> Co-authored-by: Ramesh Kumar Chandra <[email protected]> Co-authored-by: Bavisetti Narayan <[email protected]> Co-authored-by: rahulramesha <[email protected]> Co-authored-by: rahulramesha <[email protected]> Co-authored-by: Dakshesh Jain <[email protected]> Co-authored-by: Ankush Deshmukh <[email protected]> Co-authored-by: Lakhan Baheti <[email protected]> Co-authored-by: sabith-tu <[email protected]> Co-authored-by: M. Palanikannan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem-
While switching between tabs in the cycles list page, data from the previous tab used to persist until the new data is fetched.
Screen.Recording.2023-11-08.at.1.42.48.PM.mov
Solution-
Updated the structure of how cycles are being store in the cycles store to store the different types of cycles separately, instead of storing them all under one object.
Screen.Recording.2023-11-08.at.1.45.05.PM.mov