fix: notifications option in the sidebar menu not collapsing #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
sriramveeraghanta
approved these changes
Nov 6, 2023
gwokwong
added a commit
to gwokwong/plane
that referenced
this pull request
Nov 7, 2023
* develop: (419 commits) 添加源 fix: bug fixes and ui improvement (makeplane#2674) fix: slack integration workflow (makeplane#2675) fix: In kanban issues can be shifted between the column in order_by (makeplane#2676) chore: update avatar group logic (makeplane#2672) style: updated layouts UI in the space app (makeplane#2671) fix: render the estimate select if estimate is enabled for the project (makeplane#2663) Fix/mentions spaces fix (makeplane#2667) dev: On Demand Code Build for any branch (makeplane#2668) fix: existing issues modal for cycle and module (makeplane#2664) fix: package version fixes and mentions build error fixes (makeplane#2665) fix: notifications option in the sidebar menu not collapsing (makeplane#2662) fix: handled drag and drop issue, gantt hover issue for issue peek overview (makeplane#2660) refactor: removed unused packages (makeplane#2658) fix: product tour modal bugs (makeplane#2657) [feat]: Extended Tables Support (makeplane#2596) fix: mentions enter error (makeplane#2646) chore : dropdown loading state added and project card avatar fix (makeplane#2643) refactor: archive issue (makeplane#2628) fix: open changelog in new tab (makeplane#2645) ... # Conflicts: # apiserver/Dockerfile.api # apps/app/Dockerfile.web # apps/app/components/analytics/custom-analytics/create-update-analytics-modal.tsx # apps/app/components/analytics/custom-analytics/custom-analytics.tsx # apps/app/components/analytics/custom-analytics/sidebar.tsx # apps/app/components/analytics/project-modal.tsx # apps/app/components/automation/auto-archive-automation.tsx # apps/app/components/automation/auto-close-automation.tsx # apps/app/components/automation/select-month-modal.tsx # apps/app/components/command-palette/command-k.tsx # apps/app/components/core/filters/filters-list.tsx # apps/app/components/core/filters/issues-view-filter.tsx # apps/app/components/core/modals/bulk-delete-issues-modal.tsx # apps/app/components/core/sidebar/links-list.tsx # apps/app/components/core/sidebar/sidebar-progress-stats.tsx # apps/app/components/core/theme/custom-theme-selector.tsx # apps/app/components/core/views/all-views.tsx # apps/app/components/core/views/board-view/all-boards.tsx # apps/app/components/core/views/board-view/single-board.tsx # apps/app/components/core/views/calendar-view/calendar-header.tsx # apps/app/components/core/views/calendar-view/single-date.tsx # apps/app/components/core/views/issues-view.tsx # apps/app/components/core/views/list-view/single-list.tsx # apps/app/components/core/views/spreadsheet-view/single-issue.tsx # apps/app/components/core/views/spreadsheet-view/spreadsheet-columns.tsx # apps/app/components/core/views/spreadsheet-view/spreadsheet-view.tsx # apps/app/components/cycles/sidebar.tsx # apps/app/components/cycles/single-cycle-card.tsx # apps/app/components/estimates/create-update-estimate-modal.tsx # apps/app/components/issues/comment/add-comment.tsx # apps/app/components/issues/delete-issue-modal.tsx # apps/app/components/issues/description-form.tsx # apps/app/components/issues/gantt-chart/blocks.tsx # apps/app/components/issues/modal.tsx # apps/app/components/issues/my-issues/my-issues-select-filters.tsx # apps/app/components/issues/my-issues/my-issues-view.tsx # apps/app/components/issues/select/label.tsx # apps/app/components/issues/select/project.tsx # apps/app/components/issues/sidebar-select/label.tsx # apps/app/components/issues/sidebar-select/state.tsx # apps/app/components/issues/sub-issues-list.tsx # apps/app/components/issues/view-select/assignee.tsx # apps/app/components/issues/view-select/due-date.tsx # apps/app/components/issues/view-select/label.tsx # apps/app/components/issues/view-select/priority.tsx # apps/app/components/issues/view-select/start-date.tsx # apps/app/components/labels/single-label-group.tsx # apps/app/components/labels/single-label.tsx # apps/app/components/modules/sidebar-select/select-lead.tsx # apps/app/components/modules/sidebar-select/select-members.tsx # apps/app/components/modules/sidebar.tsx # apps/app/components/modules/single-module-card.tsx # apps/app/components/onboarding/invite-members.tsx # apps/app/components/onboarding/user-details.tsx # apps/app/components/profile/profile-issues-view.tsx # apps/app/components/project/settings-header.tsx # apps/app/components/project/settings/single-label.tsx # apps/app/components/project/single-project-card.tsx # apps/app/components/tiptap/extensions/index.tsx # apps/app/components/tiptap/slash-command/index.tsx # apps/app/components/views/form.tsx # apps/app/components/views/gantt-chart.tsx # apps/app/components/views/select-filters.tsx # apps/app/components/views/single-view-item.tsx # apps/app/components/workspace/issues-stats.tsx # apps/app/components/workspace/settings-header.tsx # apps/app/components/workspace/sidebar-quick-action.tsx # apps/app/constants/calendar.ts # apps/app/constants/filters.ts # apps/app/constants/project.ts # apps/app/helpers/calendar.helper.ts # apps/app/layouts/auth-layout/project-authorization-wrapper.tsx # apps/app/layouts/auth-layout/user-authorization-wrapper.tsx # apps/app/layouts/auth-layout/workspace-authorization-wrapper.tsx # apps/app/layouts/profile-layout.tsx # apps/app/layouts/settings-navbar.tsx # apps/app/package.json # apps/app/pages/[workspaceSlug]/analytics.tsx # apps/app/pages/[workspaceSlug]/index.tsx # apps/app/pages/[workspaceSlug]/me/my-issues.tsx # apps/app/pages/[workspaceSlug]/me/profile/index.tsx # apps/app/pages/[workspaceSlug]/me/profile/preferences.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/archived-issues/index.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/cycles/[cycleId].tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/cycles/index.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/inbox/[inboxId].tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/issues/index.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/modules/[moduleId].tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/modules/index.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/pages/index.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/automations.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/control.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/estimates.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/features.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/index.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/integrations.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/labels.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/members.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/settings/states.tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/views/[viewId].tsx # apps/app/pages/[workspaceSlug]/projects/[projectId]/views/index.tsx # apps/app/pages/[workspaceSlug]/projects/index.tsx # apps/app/pages/[workspaceSlug]/settings/index.tsx # apps/app/pages/[workspaceSlug]/settings/members.tsx # apps/app/pages/api/slack-redirect.ts # apps/app/pages/create-workspace.tsx # apps/app/pages/index.tsx # apps/app/pages/invitations.tsx # apps/app/pages/magic-sign-in.tsx # apps/app/pages/onboarding.tsx # apps/app/pages/reset-password.tsx # apps/app/pages/workspace-member-invitation.tsx # apps/space/Dockerfile.space # apps/space/components/issues/filters-render/date.tsx # apps/space/components/issues/filters-render/index.tsx # apps/space/components/issues/filters-render/priority/index.tsx # docker-compose.yml # space/components/accounts/email-code-form.tsx # space/components/accounts/email-password-form.tsx # space/components/accounts/email-reset-password-form.tsx # web/components/analytics/scope-and-demand/demand.tsx # web/components/analytics/scope-and-demand/scope-and-demand.tsx # web/components/analytics/scope-and-demand/scope.tsx # web/components/auth-screens/workspace/not-a-member.tsx # web/components/command-palette/issue/change-issue-priority.tsx # web/components/command-palette/shortcuts-modal.tsx # web/components/core/activity.tsx # web/components/core/modals/existing-issues-list-modal.tsx # web/components/core/modals/image-upload-modal.tsx # web/components/core/modals/link-modal.tsx # web/components/estimates/delete-estimate-modal.tsx # web/components/estimates/estimate-list-item.tsx # web/components/inbox/filters-dropdown.tsx # web/components/inbox/filters-list.tsx # web/components/inbox/main-content.tsx # web/components/inbox/modals/select-duplicate.tsx # web/components/integration/delete-import-modal.tsx # web/components/integration/jira/give-details.tsx # web/components/integration/jira/import-users.tsx # web/components/issues/activity.tsx # web/components/issues/comment/comment-card.tsx # web/components/issues/draft-issue-form.tsx # web/components/issues/parent-issues-list-modal.tsx # web/components/issues/peek-overview/issue-properties.tsx # web/components/issues/select/assignee.tsx # web/components/issues/select/priority.tsx # web/components/issues/select/state.tsx # web/components/issues/sidebar-select/assignee.tsx # web/components/issues/sidebar-select/priority.tsx # web/components/issues/sidebar.tsx # web/components/labels/create-label-modal.tsx # web/components/labels/create-update-label-inline.tsx # web/components/labels/delete-label-modal.tsx # web/components/labels/labels-list-modal.tsx # web/components/modules/delete-module-modal.tsx # web/components/modules/form.tsx # web/components/notifications/select-snooze-till-modal.tsx # web/components/onboarding/tour/root.tsx # web/components/onboarding/workspace.tsx # web/components/pages/delete-page-modal.tsx # web/components/pages/page-form.tsx # web/components/pages/pages-list/recent-pages-list.tsx # web/components/pages/pages-view.tsx # web/components/project/confirm-project-member-remove.tsx # web/components/project/create-project-modal.tsx # web/components/project/delete-project-modal.tsx # web/components/project/join-project-modal.tsx # web/components/project/sidebar-list-item.tsx # web/components/project/sidebar-list.tsx # web/components/states/create-state-modal.tsx # web/components/states/create-update-state-inline.tsx # web/components/ui/datepicker.tsx # web/components/ui/multi-level-dropdown.tsx # web/components/views/delete-view-modal.tsx # web/components/workspace/confirm-workspace-member-remove.tsx # web/components/workspace/create-workspace-form.tsx # web/components/workspace/help-section.tsx # web/components/workspace/issues-list.tsx # web/components/workspace/send-workspace-invitation-modal.tsx # web/components/workspace/sidebar-dropdown.tsx # web/components/workspace/sidebar-menu.tsx # web/components/workspace/views/modal.tsx # web/helpers/date-time.helper.ts # web/helpers/issue.helper.ts # web/pages/404.tsx # web/pages/[workspaceSlug]/me/profile/activity.tsx # web/pages/[workspaceSlug]/projects/[projectId]/issues/[issueId].tsx # web/pages/[workspaceSlug]/projects/[projectId]/pages/[pageId].tsx # web/pages/accounts/sign-up.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the sidebar collapsed state for the notifications option.
Before fix-
Screen.Recording.2023-11-06.at.2.07.12.PM.mov
After fix-
Screen.Recording.2023-11-06.at.2.07.58.PM.mov