chore: speedup replace-env-vars.sh #1146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of this script uses
find
to enumerate all files under the app directory, then reads all of those files in a single while loop to applysed
. This is extremely slow with ~80k files during build time. We don't need to read all these files like that; we can use grep to search for files that we actually need to update and then parallelize the sed command to do it.I ran
shellcheck
against the script to make sure I didn't introduce any obvious new footguns and made suredocker-compose -f docker-compose.yml up --build
still built the image and ran without issues.