Skip to content

Commit

Permalink
Return key name
Browse files Browse the repository at this point in the history
only insert missing keys
use serializer to return data
  • Loading branch information
sangeethailango committed Jan 6, 2025
1 parent 901164b commit 6997528
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 5 deletions.
12 changes: 11 additions & 1 deletion apiserver/plane/app/serializers/workspace.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,17 @@ def get_entity_data(self, obj):


class WorkspaceHomePreferenceSerializer(BaseSerializer):
name = serializers.SerializerMethodField()

class Meta:
model = WorkspaceHomePreference
fields = ["user", "key", "is_enabled", "sort_order"]
fields = ["key", "is_enabled", "sort_order", "name"]
read_only_fields = ["worspace", "created_by", "update_by"]

def get_name(self, obj):
preference_key = obj.key

for key, name in WorkspaceHomePreference.HomeWidgetKeys.choices:
if preference_key == key:
return name
return None
6 changes: 2 additions & 4 deletions apiserver/plane/app/views/workspace/preference.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,9 @@ def get(self, request, slug):
batch_size=10,
ignore_conflicts=True,
)
serializer = WorkspaceHomePreferenceSerializer(get_preference, many=True)

return Response(
get_preference.values("key", "is_enabled", "sort_order", "config"),
status=status.HTTP_200_OK,
)
return Response(serializer.data, status=status.HTTP_200_OK)

@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")
def patch(self, request, slug, key):
Expand Down

0 comments on commit 6997528

Please sign in to comment.