reduced the components moved (#6110)

makeplane · Dec 2, 2024 · 5150c66 · 5150c66
1 parent 63bc01f
commit 5150c66
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 6 deletions.
diff --git a/web/app/[workspaceSlug]/(projects)/notifications/layout.tsx b/web/app/[workspaceSlug]/(projects)/notifications/layout.tsx
@@ -1,7 +1,7 @@
 "use client";
 
 // components
-import { NotificationsSidebar } from "@/components/workspace-notifications";
+import { NotificationsSidebar } from "@/plane-web/components/workspace-notifications";
 
 export default function ProjectInboxIssuesLayout({ children }: { children: React.ReactNode }) {
   return (

diff --git a/web/ce/components/workspace-notifications/index.ts b/web/ce/components/workspace-notifications/index.ts
@@ -0,0 +1 @@
+export * from './root'
diff --git a/.../workspace-notifications/sidebar/root.tsx → ...mponents/workspace-notifications/root.tsx b/.../workspace-notifications/sidebar/root.tsx → ...mponents/workspace-notifications/root.tsx
@@ -1,6 +1,6 @@
 "use client";
 
-import { FC } from "react";
+import { FC, useCallback } from "react";
 import { observer } from "mobx-react";
 import { useParams } from "next/navigation";
 // components
@@ -14,7 +14,7 @@ import {
   NotificationCardListRoot,
 } from "@/components/workspace-notifications";
 // constants
-import { NOTIFICATION_TABS } from "@/constants/notification";
+import { NOTIFICATION_TABS, TNotificationTab } from "@/constants/notification";
 // helpers
 import { cn } from "@/helpers/common.helper";
 import { getNumberCount } from "@/helpers/string.helper";
@@ -37,6 +37,15 @@ export const NotificationsSidebar: FC = observer(() => {
   const workspace = workspaceSlug ? getWorkspaceBySlug(workspaceSlug.toString()) : undefined;
   const notificationIds = workspace ? notificationIdsByWorkspaceId(workspace.id) : undefined;
 
+  const handleTabClick = useCallback(
+    (tabValue: TNotificationTab) => {
+      if (currentNotificationTab !== tabValue) {
+        setCurrentNotificationTab(tabValue);
+      }
+    },
+    [currentNotificationTab, setCurrentNotificationTab]
+  );
+
   if (!workspaceSlug || !workspace) return <></>;
 
   return (
@@ -56,7 +65,7 @@ export const NotificationsSidebar: FC = observer(() => {
             <div
               key={tab.value}
               className="h-full px-3 relative cursor-pointer"
-              onClick={() => currentNotificationTab != tab.value && setCurrentNotificationTab(tab.value)}
+              onClick={()=>handleTabClick(tab.value)}
             >
               <div
                 className={cn(

diff --git a/web/core/components/workspace-notifications/sidebar/index.ts b/web/core/components/workspace-notifications/sidebar/index.ts
@@ -1,8 +1,6 @@
 export * from "./loader";
 export * from "./empty-state";
 
-export * from "./root";
-
 export * from "./header";
 
 export * from "./filters";

diff --git a/web/ee/components/workspace-notifications/root.tsx b/web/ee/components/workspace-notifications/root.tsx
@@ -0,0 +1 @@
+export  {NotificationsSidebar} from 'ce/components/workspace-notifications'
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export {NotificationsSidebar} from 'ce/components/workspace-notifications'