Enable sort order to be updatable

makeplane · Jan 6, 2025 · 1d60d14 · 1d60d14
1 parent 3d66618
commit 1d60d14
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/apiserver/plane/app/urls/workspace.py b/apiserver/plane/app/urls/workspace.py
@@ -236,7 +236,7 @@
         name="workspace-home-preference",
     ),
     path(
-        "workspaces/<str:slug>/home-preferences/<uuid:pk>/",
+        "workspaces/<str:slug>/home-preferences/<str:key>/",
         WorkspacePreferenceViewSet.as_view(),
         name="workspace-home-preference",
     ),

diff --git a/apiserver/plane/app/views/workspace/preference.py b/apiserver/plane/app/views/workspace/preference.py
@@ -49,16 +49,24 @@ def get(self, request, slug):
         return Response(workspace_user_home_preferences, status=status.HTTP_200_OK)
 
     @allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST], level="WORKSPACE")
-    def patch(self, request, slug, pk):
-        preference = WorkspaceHomePreference.objects.filter(pk=pk, workspace__slug=slug)
+    def patch(self, request, slug, key):
+        preference = WorkspaceHomePreference.objects.filter(
+            key=key, workspace__slug=slug
+        )
 
         if preference:
-            WorkspaceHomePreference.objects.update(
-                is_enabled=request.data["is_enabled"]
-            )
+            if "is_enabled" in request.data:
+                WorkspaceHomePreference.objects.update(
+                    is_enabled=request.data["is_enabled"]
+                )
+
+            if "sort_order" in request.data:
+                WorkspaceHomePreference.objects.update(
+                    sort_order=request.data["sort_order"]
+                )
 
         preference = WorkspaceHomePreference.objects.filter(
-            pk=pk, user=request.user
+            key=key, user=request.user
         ).values("key", "is_enabled", "sort_order", "config", "id")
 
         return Response(preference, status=status.HTTP_200_OK)