fix: convert image size to string (#5717)

makeplane · Sep 27, 2024 · 04686d1 · 04686d1
1 parent ec08fb0
commit 04686d1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/editor/src/core/extensions/custom-image/components/image-block.tsx b/packages/editor/src/core/extensions/custom-image/components/image-block.tsx
@@ -11,7 +11,10 @@ export const CustomImageBlock: React.FC<CustomImageNodeViewProps> = (props) => {
   const { node, updateAttributes, selected, getPos, editor } = props;
   const { src, width, height } = node.attrs;
 
-  const [size, setSize] = useState({ width: width || "35%", height: height || "auto" });
+  const [size, setSize] = useState({
+    width: width?.toString() || "35%",
+    height: height?.toString() || "auto",
+  });
   const [isLoading, setIsLoading] = useState(true);
   const [initialResizeComplete, setInitialResizeComplete] = useState(false);
   const isShimmerVisible = isLoading || !initialResizeComplete;
@@ -56,7 +59,10 @@ export const CustomImageBlock: React.FC<CustomImageNodeViewProps> = (props) => {
   }, [width, height, updateAttributes]);
 
   useLayoutEffect(() => {
-    setSize({ width, height });
+    setSize({
+      width: width?.toString(),
+      height: height?.toString(),
+    });
   }, [width, height]);
 
   const handleResizeStart = useCallback(

diff --git a/packages/editor/src/core/extensions/custom-image/components/image-node.tsx b/packages/editor/src/core/extensions/custom-image/components/image-node.tsx
@@ -15,8 +15,8 @@ export type CustomImageNodeViewProps = {
   node: ProsemirrorNode & {
     attrs: {
       src: string;
-      width: string;
-      height: string;
+      width: number | string;
+      height: number | string;
     };
   };
   updateAttributes: (attrs: Record<string, any>) => void;