Skip to content

Postgres version update and minio client image add in values file #46 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/plane-ce/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ description: Meet Plane. An open-source software development tool to manage issu

type: application

version: 1.0.26
appVersion: "0.23.0"
version: 1.0.27
appVersion: "0.24.0"

home: https://plane.so
icon: https://plane.so/favicon/favicon-32x32.png
Expand Down
3 changes: 2 additions & 1 deletion charts/plane-ce/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
| Setting | Default | Required | Description |
|---|:---:|:---:|---|
| postgres.local_setup | true | | Plane uses `postgres` as the primary database to store all the transactional data. This database can be hosted within kubernetes as part of helm chart deployment or can be used as hosted service remotely (e.g. aws rds or similar services). Set this to `true` when you choose to setup stateful deployment of `postgres`. Mark it as `false` when using a remotely hosted database |
| postgres.image | postgres:15.5-alpine | | Using this key, user must provide the docker image name to setup the stateful deployment of `postgres`. (must be set when `postgres.local_setup=true`)|
| postgres.image | postgres:15.7-alpine | | Using this key, user must provide the docker image name to setup the stateful deployment of `postgres`. (must be set when `postgres.local_setup=true`)|
| postgres.servicePort | 5432 | | This key sets the default port number to be used while setting up stateful deployment of `postgres`. |
| postgres.cliConnectPort | | | If you intend to access the hosted stateful deployment of postgres using any of the client tools (e.g Postico), this key helps you expose the port. The mentioned port must not be occupied by any other applicaiton |
| postgres.volumeSize | 5Gi | | While setting up the stateful deployment, while creating the persistant volume, volume allocation size need to be provided. This key helps you set the volume allocation size. Unit of this value must be in Mi (megabyte) or Gi (gigabyte) |
Expand Down Expand Up @@ -122,6 +122,7 @@
|---|:---:|:---:|---|
| minio.local_setup | true | | Plane uses `minio` as the default file storage drive. This storage can be hosted within kubernetes as part of helm chart deployment or can be used as hosted service remotely (e.g. aws S3 or similar services). Set this to `true` when you choose to setup stateful deployment of `postgres`. Mark it as `false` when using a remotely hosted database |
| minio.image | minio/minio:latest | | Using this key, user must provide the docker image name to setup the stateful deployment of `minio`. (must be set when `minio.local_setup=true`)|
| minio.image_mc | minio/mc:latest | | Using this key, user must provide the docker image name to setup the job deployment of `minio client`. (must be set when `services.minio.local_setup=true`)|
| minio.volumeSize | 5Gi | | While setting up the stateful deployment, while creating the persistant volume, volume allocation size need to be provided. This key helps you set the volume allocation size. Unit of this value must be in Mi (megabyte) or Gi (gigabyte) |
| minio.root_user | admin | | Storage credentials are requried to access the hosted stateful deployment of `minio`. Use this key to set the username for the stateful deployment. |
| minio.root_password | password | | Storage credentials are requried to access the hosted stateful deployment of `minio`. Use this key to set the password for the stateful deployment. |
Expand Down
54 changes: 29 additions & 25 deletions charts/plane-ce/questions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ questions:
label: "Image Pull Policy"
type: enum
options:
- "Always"
- "IfNotPresent"
- "Never"
- "Always"
- "IfNotPresent"
- "Never"
default: "IfNotPresent"
- variable: web.replicas
label: "Default Replica Count"
Expand All @@ -54,7 +54,6 @@ questions:
label: "Assign Cluster IP"
type: boolean
default: false


- variable: space.image
label: Space Docker Image
Expand All @@ -67,9 +66,9 @@ questions:
label: "Image Pull Policy"
type: enum
options:
- "Always"
- "IfNotPresent"
- "Never"
- "Always"
- "IfNotPresent"
- "Never"
default: "IfNotPresent"
- variable: space.replicas
label: "Default Replica Count"
Expand Down Expand Up @@ -99,9 +98,9 @@ questions:
label: "Image Pull Policy"
type: enum
options:
- "Always"
- "IfNotPresent"
- "Never"
- "Always"
- "IfNotPresent"
- "Never"
default: "IfNotPresent"
- variable: admin.replicas
label: "Default Replica Count"
Expand Down Expand Up @@ -132,9 +131,9 @@ questions:
label: "Image Pull Policy"
type: enum
options:
- "Always"
- "IfNotPresent"
- "Never"
- "Always"
- "IfNotPresent"
- "Never"
default: "IfNotPresent"
- variable: live.replicas
label: "Default Replica Count"
Expand All @@ -152,7 +151,7 @@ questions:
label: "Assign Cluster IP"
type: boolean
default: false

- variable: env.live_sentry_dsn
label: "Live Sentry DSN"
type: string
Expand All @@ -178,9 +177,9 @@ questions:
label: "Image Pull Policy"
type: enum
options:
- "Always"
- "IfNotPresent"
- "Never"
- "Always"
- "IfNotPresent"
- "Never"
default: "IfNotPresent"
- variable: api.replicas
label: "Default Replica Count"
Expand Down Expand Up @@ -217,6 +216,7 @@ questions:
default: "60gp0byfz2dvffa45cxl20p1scy9xbpf6d8c5y0geejgkyp1b5"
subquestions:


- variable: worker.replicas
label: "Default Replica Count"
type: int
Expand Down Expand Up @@ -294,7 +294,7 @@ questions:
- variable: postgres.image
label: "Docker Image"
type: string
default: "postgres:15.5-alpine"
default: "postgres:15.7-alpine"
show_if: "postgres.local_setup=true"
- variable: postgres.servicePort
label: Service Port
Expand Down Expand Up @@ -356,9 +356,9 @@ questions:
label: "Image Pull Policy"
type: enum
options:
- "Always"
- "IfNotPresent"
- "Never"
- "Always"
- "IfNotPresent"
- "Never"
default: "IfNotPresent"
show_if: "rabbitmq.local_setup=true"
- variable: rabbitmq.servicePort
Expand Down Expand Up @@ -412,6 +412,11 @@ questions:
type: string
default: "minio/minio:latest"
show_if: "minio.local_setup=true"
- variable: minio.image_mc
label: "MinIO Client Docker Image"
type: string
default: "minio/mc:latest"
show_if: "minio.local_setup=true"
- variable: minio.root_user
label: "Root User"
type: string
Expand Down Expand Up @@ -506,9 +511,9 @@ questions:
label: "SSL Issuer"
type: enum
options:
- "http"
- "cloudflare"
- "digitalocean"
- "http"
- "cloudflare"
- "digitalocean"
default: "http"
- variable: ssl.server
label: "Let's Encrypt Server URL"
Expand All @@ -528,4 +533,3 @@ questions:
label: "Enable to generate certificates"
type: boolean
default: false

2 changes: 1 addition & 1 deletion charts/plane-ce/templates/workloads/minio.stateful.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ spec:
- secretRef:
name: {{ .Release.Name }}-doc-store-secrets
optional: false
image: minio/mc
image: {{ .Values.minio.image_mc }}
imagePullPolicy: {{ .Values.minio.pullPolicy }}
name: {{ .Release.Name }}-minio-bucket
serviceAccount: {{ .Release.Name }}-srv-account
Expand Down
3 changes: 2 additions & 1 deletion charts/plane-ce/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ redis:

postgres:
local_setup: true
image: postgres:15.5-alpine
image: postgres:15.7-alpine
servicePort: 5432
cliConnectPort: ""
storageClass: longhorn
Expand All @@ -59,6 +59,7 @@ rabbitmq:

minio:
image: minio/minio:latest
image_mc: minio/mc:latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Avoid using 'latest' tag for MinIO client image

While the addition of the MinIO client image configuration is good, using the 'latest' tag in production environments is not recommended as it:

  1. Makes deployments non-deterministic
  2. Can cause unexpected behavior during updates
  3. Makes rollbacks difficult

Consider using a specific version tag instead:

-  image_mc: minio/mc:latest
+  image_mc: minio/mc:RELEASE.2024-03-25T16-41-14Z
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
image_mc: minio/mc:latest
image_mc: minio/mc:RELEASE.2024-03-25T16-41-14Z

local_setup: true
pullPolicy: IfNotPresent
root_password: password
Expand Down
4 changes: 2 additions & 2 deletions charts/plane-enterprise/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ description: Meet Plane. An Enterprise software development tool to manage issue

type: application

version: 1.1.0
appVersion: "1.5.0"
version: 1.1.1
appVersion: "1.5.1"

home: https://plane.so/
icon: https://plane.so/favicon/favicon-32x32.png
Expand Down
3 changes: 2 additions & 1 deletion charts/plane-enterprise/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
| Setting | Default | Required | Description |
|---|:---:|:---:|---|
| services.postgres.local_setup | true | | Plane uses `postgres` as the primary database to store all the transactional data. This database can be hosted within kubernetes as part of helm chart deployment or can be used as hosted service remotely (e.g. aws rds or similar services). Set this to `true` when you choose to setup stateful deployment of `postgres`. Mark it as `false` when using a remotely hosted database |
| services.postgres.image | registry.plane.tools/plane/postgres:15.5-alpine | | Using this key, user must provide the docker image name to setup the stateful deployment of `postgres`. (must be set when `services.postgres.local_setup=true`)|
| services.postgres.image | registry.plane.tools/plane/postgres:15.7-alpine | | Using this key, user must provide the docker image name to setup the stateful deployment of `postgres`. (must be set when `services.postgres.local_setup=true`)|
| services.postgres.servicePort | 5432 | | This key sets the default port number to be used while setting up stateful deployment of `postgres`. |
| services.postgres.cliConnectPort | | | If you intend to access the hosted stateful deployment of postgres using any of the client tools (e.g Postico), this key helps you expose the port. The mentioned port must not be occupied by any other applicaiton|
| services.postgres.volumeSize | 2Gi | | While setting up the stateful deployment, while creating the persistant volume, volume allocation size need to be provided. This key helps you set the volume allocation size. Unit of this value must be in Mi (megabyte) or Gi (gigabyte) |
Expand Down Expand Up @@ -147,6 +147,7 @@
|---|:---:|:---:|---|
| services.minio.local_setup | true | | Plane uses `minio` as the default file storage drive. This storage can be hosted within kubernetes as part of helm chart deployment or can be used as hosted service remotely (e.g. aws S3 or similar services). Set this to `true` when you choose to setup stateful deployment of `minio`. Mark it as `false` when using a remotely hosted database |
| services.minio.image | registry.plane.tools/plane/minio:latest | | Using this key, user must provide the docker image name to setup the stateful deployment of `minio`. (must be set when `services.minio.local_setup=true`)|
| services.minio.image_mc | minio/mc:latest | | Using this key, user must provide the docker image name to setup the job deployment of `minio client`. (must be set when `services.minio.local_setup=true`)|
| services.minio.volumeSize | 3Gi | | While setting up the stateful deployment, while creating the persistant volume, volume allocation size need to be provided. This key helps you set the volume allocation size. Unit of this value must be in Mi (megabyte) or Gi (gigabyte) |
| services.minio.root_user | admin | | Storage credentials are requried to access the hosted stateful deployment of `minio`. Use this key to set the username for the stateful deployment. |
| services.minio.root_password | password | | Storage credentials are requried to access the hosted stateful deployment of `minio`. Use this key to set the password for the stateful deployment. |
Expand Down
18 changes: 11 additions & 7 deletions charts/plane-enterprise/questions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ questions:
label: "Assign Cluster IP"
type: boolean
default: false

- variable: services.space.replicas
label: "Default Replica Count"
type: int
Expand Down Expand Up @@ -285,7 +285,7 @@ questions:
- variable: services.postgres.image
label: "Docker Image"
type: string
default: "registry.plane.tools/plane/postgres:15.5-alpine"
default: "registry.plane.tools/plane/postgres:15.7-alpine"
show_if: "services.postgres.local_setup=true"
- variable: services.postgres.servicePort
label: Service Port
Expand Down Expand Up @@ -372,7 +372,7 @@ questions:
label: "Remote URL"
type: string
show_if: "services.rabbitmq.local_setup=false"

- variable: services.minio.local_setup
label: "Install Minio"
type: boolean
Expand All @@ -384,6 +384,11 @@ questions:
type: string
default: "registry.plane.tools/plane/minio:latest"
show_if: "services.minio.local_setup=true"
- variable: services.minio.image_mc
label: "MinIO Client Docker Image"
type: string
default: "minio/mc:latest"
show_if: "services.minio.local_setup=true"
- variable: services.minio.root_user
label: "Root User"
type: string
Expand Down Expand Up @@ -470,9 +475,9 @@ questions:
label: "SSL Issuer"
type: enum
options:
- "http"
- "cloudflare"
- "digitalocean"
- "http"
- "cloudflare"
- "digitalocean"
default: "http"
- variable: ssl.server
label: "Let's Encrypt Server URL"
Expand All @@ -492,4 +497,3 @@ questions:
label: "Enable to generate certificates"
type: boolean
default: false

Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ spec:
- secretRef:
name: {{ .Release.Name }}-doc-store-secrets
optional: false
image: minio/mc
image: {{ .Values.services.minio.image_mc }}
imagePullPolicy: Always
name: {{ .Release.Name }}-minio-bucket
serviceAccount: {{ .Release.Name }}-srv-account
Expand Down
5 changes: 3 additions & 2 deletions charts/plane-enterprise/values.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
planeVersion: v1.5.0
planeVersion: v1.5.1

dockerRegistry:
enabled: false
Expand Down Expand Up @@ -37,7 +37,7 @@ services:

postgres:
local_setup: true
image: registry.plane.tools/plane/postgres:15.5-alpine
image: registry.plane.tools/plane/postgres:15.7-alpine
servicePort: 5432
cliConnectPort: ''
volumeSize: 2Gi
Expand All @@ -57,6 +57,7 @@ services:
minio:
local_setup: true
image: registry.plane.tools/plane/minio:latest
image_mc: minio/mc:latest
volumeSize: 3Gi
root_user: admin
root_password: password
Expand Down