-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External secrets #58
base: develop
Are you sure you want to change the base?
External secrets #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate you picking up the work on this as it will be hugely helpful for our deployment scenario!
charts/plane-ce/values.yaml
Outdated
rabbitmq_secrets: '' | ||
pgdb_secrets: '' | ||
doc_store_secrets: '' | ||
app_env_secrets: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I suggest using the conventional value name existingSecret
used across many helm charts?
rabbitmq_secrets: '' | |
pgdb_secrets: '' | |
doc_store_secrets: '' | |
app_env_secrets: '' | |
# Name of the existing Kubernetes Secret resource; see README for more details | |
rabbitmq_existingSecret: '' | |
pgdb_existingSecret: '' | |
doc_store_existingSecret: '' | |
app_env_existingSecret: '' |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
No description provided.