fix: adjust uploads path regex to support trailing slashes #57
Conversation
WalkthroughThe changes in this pull request involve updates to Kubernetes configuration files for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Ingress
participant MinIO
participant API
User->>Ingress: Request to MinIO
Ingress->>MinIO: Route request to /{{ .Values.env.docstore_bucket }}
MinIO-->>Ingress: Response
User->>Ingress: Request to GraphQL
Ingress->>API: Route request to /graphql/
API-->>Ingress: Response
Ingress-->>User: Return responses
Possibly related PRs
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
charts/plane-ce/templates/config-secrets/app-env.yaml (1)
9-9: Remove trailing whitespace.
There is trailing whitespace on this line that should be removed.
-
+🧰 Tools
🪛 yamllint
[error] 9-9: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- charts/plane-ce/templates/config-secrets/app-env.yaml (1 hunks)
🧰 Additional context used
🪛 yamllint
charts/plane-ce/templates/config-secrets/app-env.yaml
[error] 9-9: trailing spaces
(trailing-spaces)
🔇 Additional comments (2)
charts/plane-ce/templates/config-secrets/app-env.yaml (2)
Line range hint 39-59: Verify connection URL patterns.
The database and message queue connection strings should be validated to ensure they follow the expected format. Consider adding validation helpers or documentation for the expected URL patterns.
Let's check for any existing URL validation or documentation:
#!/bin/bash
# Search for URL validation or connection string documentation
rg -i "(database|redis|amqp).?url.?(format|pattern|validation)" --type md🧰 Tools
🪛 yamllint
[error] 9-9: trailing spaces
(trailing-spaces)
[error] 6-6: syntax error: expected , but found ''
(syntax)
Line range hint 27-37: Enhance CORS configuration validation.
The CORS configuration could benefit from additional validation to ensure secure defaults:
- When
cors_allowed_originsis "*", it allows all origins which might be too permissive - There's no validation for malformed URLs in the custom CORS origins
Let's check if there are any security guidelines or documentation about CORS configuration:
#!/bin/bash
# Search for CORS-related documentation or security guidelines
rg -i "cors.?(allowed.?origins|security|configuration)" --type md🧰 Tools
🪛 yamllint
[error] 9-9: trailing spaces
(trailing-spaces)
[error] 6-6: syntax error: expected , but found ''
(syntax)
update uploads path regex to allow trailing slash (
/uploads,/uploads/)Summary by CodeRabbit
New Features
Version Updates