-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-redux
to 6, adhere to React Context API
#135
Conversation
react-redux
to 6react-redux
to 6, adhere to React Context API
…eact context API. Also, upgrades to the latest react-router-config beta version, adds the react-router-dom extra package as peer dependency, and upgrade all the other dependencies to their latest minor/major versions.
@ioanlucut thanks for the PR, this looks really good - only concern I have is that we reserve "store" property and it could potentially break the apps using it, what do you think? |
@AVVS thank you for having a look.
? |
yeah, this bit |
@AVVS I can rename this prop to be e.g. |
@aleksxor I would appreciate a lot if you'd take some minutes to review this PR. Thanks! |
the PR looks pretty good for me. though I have the same concern about prop naming. something like |
…yncConnect to avoid possible collisions
@aleksxor thanks for the feedback and the approval. Waiting for the merge and release! :) |
@AVVS When you find some time, please re-check! Thank you! |
Hi @AVVS ! I am sorry for stressing you out, but I'd appreciate a lot getting this PR merged. |
In order to adhere to the new React context API.
Also, upgrades to the latest react-router-config beta version, adds the react-router-dom extra package as peer dependency, and upgrade all the other dependencies to their latest minor/major versions.
Also, drops the node 9 support, and focus on the LTE version of node (8, 10).
I got inspired from: