Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sinf patch when app contains a Watch App #140

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

Itaybre
Copy link
Contributor

@Itaybre Itaybre commented Jan 22, 2023

Issue

When apps contain a watch app, their bundle name is selected for applying the Sina patch

Examples:

  • Starbucks com.starbucks.mystarbucks
  • Yelp com.yelp.yelpiphone

Fix

Ignore app bundles that contain /Watch/ in the path

@majd
Copy link
Owner

majd commented Jan 22, 2023

Thank you! Would you mind updating the test case for modern FairPlay protection to cover this logic?

@Itaybre
Copy link
Contributor Author

Itaybre commented Jan 22, 2023

Thank you! Would you mind updating the test case for modern FairPlay protection to cover this logic?

Ready, I added a new test case for apps with Watch Apps

@majd majd merged commit 50a1e54 into majd:main Jan 23, 2023
@Itaybre Itaybre deleted the feature/fix_watch_apps branch April 25, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants