Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: support kserve with authorino #12

Conversation

aslakknutsen
Copy link
Member

bartoszmajsak and others added 22 commits October 3, 2023 12:50
- rename k8serrors to apierrs for consistency
- Use controllerutil methods add and remove finalizer

Signed-off-by: Wen Zhou <[email protected]>
* Activate extauth for grpc traffic
* Set host on requests from activator to trigger authconfig
* Temp Authorization header fix to workaround https://issues.redhat.com/browse/OSSM-4873
@bartoszmajsak
Copy link

@aslakknutsen how can I test it?

@aslakknutsen
Copy link
Member Author

Not much to test beyond that they get installed. This depends on a few other PRs coming elsewhere

@aslakknutsen
Copy link
Member Author

aslakknutsen commented Oct 3, 2023

You can always setup a echo service on port 8013 with label "component: predicator" and;

  • call it by ip and use header k-original-host with a host name and see it end up as Host in the echo request
  • call something that's "pass_through" in extAuth with an Authorization header and see it's still there when it reach the target

@bartoszmajsak
Copy link

As for the linter errors, I will soon push cleanup to the target branch so we will see if there's anything left in your PR

@bartoszmajsak
Copy link

Closes, as it's been reworked in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants