MAISTRA-2648: WASM fix for s390x#134
Conversation
|
Hi @knm3000. Thanks for your PR. I'm waiting for a maistra member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
Note: I tagged this PR with |
|
Sorry - I misread the target branch; please disregard the earlier comment. I removed the |
|
/retest |
bazel/repositories.bzl
Outdated
| build_file = "@envoy//bazel/external:proxy_wasm_cpp_host.BUILD", | ||
| # The patch fixes WASM on s390x https://issues.redhat.com/browse/MAISTRA-2648 | ||
| # The permanent fix is https://github.com/proxy-wasm/proxy-wasm-cpp-host/pull/198 | ||
| patches = ["@envoy//bazel/external:proxy_wasm_cpp_host.patch"], |
There was a problem hiding this comment.
nit: Generally speaking it's a good idea to name the file after its meaning or purpose, or even with the title of the original patch, instead of naming it with the name of the package. What if, in the future there is another patch for this same package?
There was a problem hiding this comment.
Renamed the patch file name to proxy_wasm_s390x.patch.
Fixes https://issues.redhat.com/browse/MAISTRA-2648 The permanent fix is not a part of maistra/envoy yet: proxy-wasm/proxy-wasm-cpp-host#198 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
|
/retest |
|
/retest |
Fixes https://issues.redhat.com/browse/MAISTRA-2648 The permanent fix is not a part of maistra/envoy yet: proxy-wasm/proxy-wasm-cpp-host#198 Signed-off-by: Konstantin Maksimov <konstantin.maksimov@ibm.com>
5 participants
Fixes https://issues.redhat.com/browse/MAISTRA-2648
The permanent fix is not a part of maistra/envoy yet:
proxy-wasm/proxy-wasm-cpp-host#198
Signed-off-by: Konstantin Maksimov konstantin.maksimov@ibm.com