Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arm64 docker image support #787

Merged
merged 2 commits into from
May 11, 2022

Conversation

samwiseg0
Copy link
Contributor

@samwiseg0 samwiseg0 commented May 10, 2022

Added arm64 image support to publish_docker.yml workflow file.

I have built and tested this workflow on my branch. Unfortunately, I could not get armv7 support to work. It seems that cypress does not support arm 32 bit. cypress-io/cypress#4478 For my purposes I only needed an arm64 image.

Added arm64 image support to publish_docker.yml workflow file
@samwiseg0 samwiseg0 changed the title feat: Add arm64 docker image support feat: add arm64 docker image support May 10, 2022
@dw-0
Copy link
Member

dw-0 commented May 11, 2022

Thanks for the contribution!
I pushed a commit to this PR to make the Prettier test succeed, so we can merge it.

@samwiseg0
Copy link
Contributor Author

Thanks for the contribution! I pushed a commit to this PR to make the Prettier test succeed, so we can merge it.

Thank you!

@dw-0 dw-0 merged commit 87cecaf into mainsail-crew:develop May 11, 2022
@samwiseg0 samwiseg0 deleted the samwiseg0-add-multiarch branch May 11, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants