Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SettingsPresetTab): improve form validation for heater preset #749

Merged
merged 1 commit into from
Apr 10, 2022
Merged

fix(SettingsPresetTab): improve form validation for heater preset #749

merged 1 commit into from
Apr 10, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Apr 10, 2022

This PR adds:

  • improved form validation
  • translations for all error messages
  • temperature values below 0°C aren't possible anymore
  • button for quickly clearing the name input field
  • placeholder for the preset name text input field

Signed-off-by: Dominik Willner [email protected]

@dw-0 dw-0 requested review from meteyou and pataar April 10, 2022 19:45
@meteyou meteyou changed the title fix(SettingsPresetTab): improve form validation for heater preset form fix(SettingsPresetTab): improve form validation for heater preset Apr 10, 2022
@meteyou meteyou merged commit e2caa99 into mainsail-crew:develop Apr 10, 2022
@dw-0 dw-0 deleted the fix-form-validation branch April 10, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteyou meteyou meteyou approved these changes

@pataar pataar Awaiting requested review from pataar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dw-0 @meteyou