Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pwa): add PWA support for https based instances #654

Merged
merged 4 commits into from
Feb 18, 2022
Merged

feat(pwa): add PWA support for https based instances #654

merged 4 commits into from
Feb 18, 2022

Conversation

pataar
Copy link
Member

@pataar pataar commented Feb 17, 2022

Due the requirement of https, this'll only be useful on https://my.mainsail.xyz. And using self-signed certificates. It doesn't hurt to add this right now, http instances won't have problems with it.

@pataar pataar added the analyze runs build size report label Feb 17, 2022
@github-actions
Copy link
Contributor

Size Change: +9.01 kB (0%)

Total Size: 1.98 MB

Filename Size Change
./dist/assets/Codemirror.js 113 kB +1 B (0%)
./dist/assets/index.js 247 kB +208 B (0%)
./dist/assets/vendor.js 587 kB +2.5 kB (0%)
./dist/assets/Viewer.js 282 kB +1 B (0%)
./dist/index.html 688 B +38 B (+6%) 🔍
./dist/sw.js 6.26 kB +6.26 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./dist/assets/Codemirror.css 20 B
./dist/assets/Heightmap.css 74 B
./dist/assets/Heightmap.js 172 kB
./dist/assets/index.css 56.4 kB
./dist/assets/materialdesignicons-webfont.woff2 354 kB
./dist/assets/vendor.css 64.5 kB
./dist/assets/Viewer.css 318 B
./dist/config.json 25 B
./dist/fonts/roboto-black.woff2 11 kB
./dist/fonts/roboto-bold.woff2 11 kB
./dist/fonts/roboto-light.woff2 11.2 kB
./dist/fonts/roboto-medium.woff2 11.1 kB
./dist/fonts/roboto-regular.woff2 11 kB
./dist/fonts/roboto-thin.woff2 11 kB
./dist/img/icons/apple-touch-icon-152x152.png 4.38 kB
./dist/img/icons/favicon-16x16.png 569 B
./dist/img/icons/favicon-32x32.png 1.05 kB
./dist/img/icons/icon-196-png 3.97 kB
./dist/img/icons/icon-512-png 11.1 kB
./dist/img/icons/mstile-150x150.png 4.26 kB
./dist/img/klipper.svg 3.4 kB
./dist/img/logo.svg 4.08 kB
./dist/img/sidebar-background.svg 1.33 kB

compressed-size-action

@github-actions github-actions bot removed the analyze runs build size report label Feb 17, 2022
@pataar pataar marked this pull request as ready for review February 17, 2022 18:46
@pataar pataar changed the title feat(pwa): add PWA support feat(pwa): add PWA support for https based instancs Feb 17, 2022
@pataar pataar changed the title feat(pwa): add PWA support for https based instancs feat(pwa): add PWA support for https based instances Feb 17, 2022
@pataar pataar marked this pull request as draft February 17, 2022 18:59
@pataar pataar marked this pull request as ready for review February 17, 2022 20:44
@meteyou meteyou merged commit db9b19e into mainsail-crew:develop Feb 18, 2022
@pataar pataar deleted the feature/add_pwa_support branch February 18, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants