chore(build): Sets Node engine to version 16 #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Lamas <[email protected]>
meteyou
changed the title
|
thx for your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one tries to build Mainsail with the latest Node (17 at the time of writing), it will not work as it has a new OpenSSL provider that is not directly compatible with some of the dependencies (though one can set
NODE_OPTIONSto--openssl-legacy-providerin order to use the legacy provider)In any case, as the current workflow is using Node 16 (LTS at time of writing), I think it would be wise to fix that version so anyone trying to build from source gets a warning if they are using a different version of Node.
Signed-off-by: Pedro Lamas [email protected]