Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve machine settings number inputs #537

Merged

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Jan 14, 2022

  • fix: truncate excessive decimal places
  • fix: add toString casting to labels
  • fix: disable spinner appropriately
  • fix: allow 3 decimal places for pressure advance smooth time
  • fix: disable both spinners if input value triggers error
  • feat: add spinnerFactor prop
  • fix: smooth time step size of 0.001
  • feat: add hasSpinner prop
  • fix: add sane values as spinnerFactor for motion and fw retract spinners

Signed-off-by: Dominik Willner [email protected]

fix: add `toString` casting to labels

fix: disable spinner appropriately

Signed-off-by: Dominik Willner <[email protected]>
@meteyou meteyou changed the title WIP fix: improve machine settings number inputs [WIP] fix: improve machine settings number inputs Jan 14, 2022
@dw-0 dw-0 requested review from meteyou and steadyjaw January 17, 2022 13:18
dw-0 added 5 commits January 18, 2022 09:45
Simple multiplicator that can be used in combination with spinners to increase/decrease values with a different step size.

Signed-off-by: Dominik Willner <[email protected]>
fix: spinnerFactor of 10

Allows for manual input of numbers with 3 decimal places. Spinners will still increase/decrease by 0.01

Signed-off-by: Dominik Willner <[email protected]>
Allows for individually activating/disabling spinners on a number input field

Signed-off-by: Dominik Willner <[email protected]>
@dw-0 dw-0 changed the title [WIP] fix: improve machine settings number inputs fix: improve machine settings number inputs Jan 18, 2022
@meteyou meteyou merged commit 595c937 into mainsail-crew:develop Jan 18, 2022
@dw-0 dw-0 deleted the fix/machine-settings-number-display branch January 18, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants