fix: Search string highlighted after pressing Ctrl+F again #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these bugfixes: > Make sure any existing search text is selected when opening the search panel. Add search config option to not match case when search panel is opened (mainsail-crew#4)
Drachenkaetzchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the version for @codemirror/search 0.19.2:
Original problem:
Ctrl+Fis hit once, and some search string is entered, a subsequentCtrl+Fdoesn't highlight the previous search string, so everything typed is appended. The usual implementation ofCtrl+Fis to mark the text in the text box, so that it can be easily overwritten-- Example: If I hit
Ctrl+F, then search for "bed", then hitCtrl+Fagain and type "temp", the search input box would contain "bedtemp" instead of "temp".As a bonus, case insensitive search is now the default and is configurable. If wanted, I can add an option to mainsail to enable case sensitive search.