Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(control): check set actionButton before display it #1953

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jul 20, 2024

Description

This PR fix the action button in the Cross & Circle control. When you set the action button to QGL and then remove QGL, then it will display the default action button instead of QGL now.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

@meteyou meteyou requested review from dw-0 and rackrick July 20, 2024 20:31
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 20, 2024
@meteyou meteyou added this to the v2.13.0 milestone Sep 7, 2024
rackrick
rackrick previously approved these changes Nov 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2024
@meteyou meteyou merged commit 69d286e into mainsail-crew:develop Nov 5, 2024
9 checks passed
@meteyou meteyou deleted the fix/fix-control-action-button branch November 5, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants