-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show filament sensor state even when the sensor is disabled #1656
feat: show filament sensor state even when the sensor is disabled #1656
Conversation
5fbf62d
to
84b782e
Compare
@EiNSTeiN- are you sure that the status will be updated even if it is disabled? i'm not sure right now and would have to reproduce and test it. i think it was a problem back then why we didn't implement it. |
Yes I verified this happen, you can see in the screenshot too that the status is What you may be remembering is the fact that the sensor status is not updated when the filament is not moving. But as long as the filament is moving, for instance whenever the printer is printing, then the internal status is updated regardless of whether the sensor is enabled or not. |
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Signed-off-by: Stefan Dej <[email protected]>
Language file analysis report:
|
Thx for your PR! i only fixed some issues in this module (some older issues i found while reviewing it. not your fault). i also removed the disabled text, because it is already visible with the switch itself. and now the text "empty" is also colored. this was a bug of the old code (so my fault) |
…rew#1656) Co-authored-by: Stefan Dej <[email protected]>
…rew#1656) Co-authored-by: Stefan Dej <[email protected]>
Description
This PR changes the FilamentSensor view so the filament state (detected or empty) is shown regardless of whether the sensor is enabled or disabled. I added the "disabled" state next to the presence state simply because I'm unaware of an alternative way to show both together, let me know if there is an existing pattern I can re-use here.
I sometimes disable my filament motion sensors but I would still like to see whether the sensor reports motion or not. This can be useful when debugging filament run-out issues, for example when the detection length is too short and the filament sensor keeps triggering but the print is actually going fine.
Mobile & Desktop Screenshots/Recordings