Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale(ja): update Japanese localization #1270

Merged
merged 5 commits into from
Mar 11, 2023
Merged

locale(ja): update Japanese localization #1270

merged 5 commits into from
Mar 11, 2023

Conversation

chai-md
Copy link
Contributor

@chai-md chai-md commented Feb 18, 2023

follow-up en.json

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
ja.json 1 1

@meteyou
Copy link
Member

meteyou commented Feb 18, 2023

Thanks for your PR! There are only one missing key and one unused key. Please add the missing key and delete the unused key.

Here is the result of the locale check:
image

@meteyou
Copy link
Member

meteyou commented Mar 10, 2023

@chai-md any news to this PR? are you able to fix this minor issues?

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
ja.json 3 1

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
ja.json 3 0

@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
ja.json 0 0

@chai-md
Copy link
Contributor Author

chai-md commented Mar 11, 2023

I was a little busy with another matter. Does this look good?

@meteyou
Copy link
Member

meteyou commented Mar 11, 2023

I was a little busy with another matter. Does this look good?

Thx! Looks perfect!

@meteyou meteyou merged commit b0cdbb4 into mainsail-crew:develop Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants