refactor: remove input validation from MoveToInput #1022
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the following problem:
The input was validated against
position_min
andposition_max
of the configuration file. If the input falls below / exceeds the boundaries set inside the config, a visible error would be shown.The real issue is, that those errors are also shown if there wasn't input from the user. The culprit in that case seems to be Klipper. The error was often reported, but wasn't possible to reproduce but looked like this:
It is suspected to be a rounding error in Klipper, hence Klipper actually reporting the wrong toolhead position which then appears to exceed the position_max by 0,01 which is enough to trigger an error during the validation methods. This often led to confusion for the user because the error simply was not comprehensible.
So the current solution aims at removing all validation from that component to reduce confusion.
As a trade-off
Move out of range
errors are then only logged in the console after submitting a move command.Signed-off-by: Dominik Willner [email protected]