Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove input validation from MoveToInput #1022

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

dw-0
Copy link
Member

@dw-0 dw-0 commented Aug 12, 2022

Solves the following problem:

The input was validated against position_min and position_max of the configuration file. If the input falls below / exceeds the boundaries set inside the config, a visible error would be shown.
The real issue is, that those errors are also shown if there wasn't input from the user. The culprit in that case seems to be Klipper. The error was often reported, but wasn't possible to reproduce but looked like this:
image

It is suspected to be a rounding error in Klipper, hence Klipper actually reporting the wrong toolhead position which then appears to exceed the position_max by 0,01 which is enough to trigger an error during the validation methods. This often led to confusion for the user because the error simply was not comprehensible.

So the current solution aims at removing all validation from that component to reduce confusion.
As a trade-off Move out of range errors are then only logged in the console after submitting a move command.

Signed-off-by: Dominik Willner [email protected]

@dw-0 dw-0 requested a review from meteyou August 12, 2022 14:20
@dw-0 dw-0 merged commit fe99958 into mainsail-crew:develop Aug 12, 2022
@dw-0 dw-0 deleted the remove-out-of-range-validation branch August 12, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants