Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isDisabled() assertion #62

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Add isDisabled() assertion #62

merged 1 commit into from
Mar 12, 2018

Conversation

rtablada
Copy link
Contributor

@rtablada rtablada commented Mar 12, 2018 •
edited by Turbo87
Loading

Worked with @habdelra at contribs workshop.

Do we care about other edgecases:

  • Setting disabled to a string value (ex. disabled="disabled")
  • Setting disabled to the value false in HTML disabled="false" (this is actually will give element.disabled === true` when accessed via JS, do we want to warn users of this edcase or leave to linting)

Resolves #38

@Turbo87 Turbo87 changed the title Closes #38. Add isDisabled() assertion Mar 12, 2018
Turbo87
Turbo87 approved these changes Mar 12, 2018
View reviewed changes
Copy link
Collaborator

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 👍

@Turbo87 Turbo87 merged commit 7b65842 into mainmatter:master Mar 12, 2018
@Turbo87 Turbo87 mentioned this pull request Apr 3, 2018
Closed
@Turbo87 Turbo87 mentioned this pull request Apr 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtablada @Turbo87