Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Adding isCSSVisible assertion #532

Closed
wants to merge 2 commits into from

Conversation

scalvert
Copy link
Collaborator

First pass at resolving #418.

I'm open to having a different approach.

TODO:

  • Generate docs
  • Add optional options object with count (TBD)

@scalvert scalvert changed the title task(assertions): WIP - Adding isCSSVisible assertion WIP - Adding isCSSVisible assertion Nov 14, 2019
@scalvert
Copy link
Collaborator Author

@Turbo87 interested in your thoughts here. If we don't feel this has legs I'd rather just close it.

@Turbo87
Copy link
Collaborator

Turbo87 commented Mar 31, 2020

@Turbo87 interested in your thoughts here

TBH I think the best way forward might be to remove the isVisible() assertion completely. There are just too many ways that this could lead to false positives or negatives and I think adding a second isVisible() assertion variant will likely make the situation worse.

@Turbo87 Turbo87 removed their request for review April 10, 2020 07:36
@scalvert scalvert closed this May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants