Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-cli to 2.18 #18

Conversation

siva-sundar
Copy link
Contributor

@siva-sundar siva-sundar commented Jan 3, 2018

Updating ember-cli to make use of Chrome headless instead of PhantomJS, since the pipeline is failing.

@siva-sundar siva-sundar changed the title Update ember-cli to 2.18 [WIP] Update ember-cli to 2.18 Jan 3, 2018
@siva-sundar siva-sundar changed the title [WIP] Update ember-cli to 2.18 Update ember-cli to 2.18 Jan 4, 2018
@siva-sundar
Copy link
Contributor Author

Some of the tests are failed I am not sure why.

@mixonic
Copy link

mixonic commented Feb 1, 2018

@siva-sundar @marcoow @Turbo87 the tests appear to run back to 2.9 and before. Is there a minimum supported version of Ember, or should the tests be running for that far back?

I would like to see a release of master soon, there are fixes included that keep an app of mine pinned to master. I'm not sure if this issue or any other should be considered a blocker.

@Turbo87
Copy link
Collaborator

Turbo87 commented Feb 2, 2018

@mixonic there is no explicit minimum supported version afaik, but I'd like to support as far back as possible, and since the AST hasn't changed much there seems to be no reason why we shouldn't be able to support these older versions.

The one thing that is blocking progress right now is figuring out why some of the tests are failing when running them with headless Chrome (see #20). Once that PR is merged we can updated to latest CLI etc. (this PR) and release a new version.

@Turbo87
Copy link
Collaborator

Turbo87 commented Feb 5, 2018

I would like to see a release of master soon, there are fixes included that keep an app of mine pinned to master. I'm not sure if this issue or any other should be considered a blocker.

🚀 I just released master as v0.2.0

/cc @mixonic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants