Skip to content

Disable Contacts::GetAll method from .NET client #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

Disable Contacts::GetAll method from .NET client #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/Mailtrap.Example.Contact/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
IContactCollectionResource contactsResource = accountResource.Contacts();

// Get all contacts for account
IList<Contact> contacts = await contactsResource.GetAll();
// TODO: Enable when GetAll is implemented
IList<Contact> contacts = /*await contactsResource.GetAll()*/ [];

Contact? contact = contacts
.FirstOrDefault(p => string.Equals(p.Email, contactEmail, StringComparison.OrdinalIgnoreCase));
Expand Down
3 changes: 2 additions & 1 deletion examples/Mailtrap.Example.ContactEvents/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
IContactCollectionResource contactsResource = accountResource.Contacts();

// Get all contacts for account
IList<Contact> contacts = await contactsResource.GetAll();
// TODO: Enable when GetAll is implemented
IList<Contact> contacts = /*await contactsResource.GetAll()*/ [];

Contact? contact = contacts.Count > 0 ? contacts[0] : null;
if (contact is null)
Expand Down
15 changes: 1 addition & 14 deletions src/Mailtrap.Abstractions/Contacts/IContactCollectionResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,19 +96,6 @@ public interface IContactCollectionResource : IRestResource
/// </returns>
public IContactEventCollectionResource Events(string contactId);

/// <summary>
/// Gets collection of contact details.
/// </summary>
///
/// <param name="cancellationToken">
/// Token to control operation cancellation.
/// </param>
///
/// <returns>
/// Collection of contact details.
/// </returns>
public Task<IList<Contact>> GetAll(CancellationToken cancellationToken = default);

/// <summary>
/// Creates a new contact with details specified by <paramref name="request"/>.
/// </summary>
Expand All @@ -118,7 +105,7 @@ public interface IContactCollectionResource : IRestResource
/// </param>
///
/// <param name="cancellationToken">
/// <inheritdoc cref="GetAll(CancellationToken)" path="/param[@name='cancellationToken']"/>
/// Token to control operation cancellation.
/// </param>
///
/// <returns>
Expand Down
80 changes: 40 additions & 40 deletions tests/Mailtrap.IntegrationTests/Contacts/ContactsIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,46 +29,46 @@ public ContactsIntegrationTests()
_jsonSerializerOptions = _clientConfig.ToJsonSerializerOptions();
}


[Test]
public async Task GetAll_Success()
{
// Arrange
var httpMethod = HttpMethod.Get;
var requestUri = _resourceUri.AbsoluteUri;

using var responseContent = await Feature.LoadFileToStringContent();

using var mockHttp = new MockHttpMessageHandler();
mockHttp
.Expect(httpMethod, requestUri)
.WithHeaders("Authorization", $"Bearer {_clientConfig.ApiToken}")
.WithHeaders("Accept", MimeTypes.Application.Json)
.WithHeaders("User-Agent", HeaderValues.UserAgent.ToString())
.Respond(HttpStatusCode.OK, responseContent);

var serviceCollection = new ServiceCollection();
serviceCollection
.AddMailtrapClient(_clientConfig)
.ConfigurePrimaryHttpMessageHandler(() => mockHttp);

using var services = serviceCollection.BuildServiceProvider();
var client = services.GetRequiredService<IMailtrapClient>();

// Act
var result = await client
.Account(_accountId)
.Contacts()
.GetAll()
.ConfigureAwait(false);

// Assert
mockHttp.VerifyNoOutstandingExpectation();

result.Should()
.NotBeNull().And
.HaveCount(3);
}
// TODO: Enable when GetAll is implemented
// [Test]
// public async Task GetAll_Success()
// {
// // Arrange
// var httpMethod = HttpMethod.Get;
// var requestUri = _resourceUri.AbsoluteUri;

// using var responseContent = await Feature.LoadFileToStringContent();

// using var mockHttp = new MockHttpMessageHandler();
// mockHttp
// .Expect(httpMethod, requestUri)
// .WithHeaders("Authorization", $"Bearer {_clientConfig.ApiToken}")
// .WithHeaders("Accept", MimeTypes.Application.Json)
// .WithHeaders("User-Agent", HeaderValues.UserAgent.ToString())
// .Respond(HttpStatusCode.OK, responseContent);

// var serviceCollection = new ServiceCollection();
// serviceCollection
// .AddMailtrapClient(_clientConfig)
// .ConfigurePrimaryHttpMessageHandler(() => mockHttp);

// using var services = serviceCollection.BuildServiceProvider();
// var client = services.GetRequiredService<IMailtrapClient>();

// // Act
// var result = await client
// .Account(_accountId)
// .Contacts()
// .GetAll()
// .ConfigureAwait(false);

// // Assert
// mockHttp.VerifyNoOutstandingExpectation();

// result.Should()
// .NotBeNull().And
// .HaveCount(3);
// }

[Test]
public async Task Create_Success()
Expand Down