Skip to content

Feature - Add batch email support to .NET client #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Oct 28, 2025
Merged

Feature - Add batch email support to .NET client #158

Show file tree
Hide file tree
Changes from 20 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
1ce3733
Created BulkEmailRequest model and validators. Refactored existing em…
zhaparoff Apr 2, 2025
55b2dcd
Renamed abstractions to align with API naming.
zhaparoff Apr 2, 2025
e580b58
Updates NuGet
zhaparoff Apr 2, 2025
07bd2ca
Add response, cleanup tests.
zhaparoff Apr 2, 2025
9607b81
Batch WiP
zhaparoff Apr 6, 2025
8c2c6d1
Merge latest main
zhaparoff Apr 16, 2025
dc773a0
Batch emails implementation + tests
zhaparoff Apr 16, 2025
56ab5e7
Adds integration tests for batch email
zhaparoff May 7, 2025
59fc39f
Merge branch 'main' into feature/bulk-email
dr-3lo Sep 23, 2025
5b0b289
Merge branch 'main' into feature/bulk-email
dr-3lo Sep 26, 2025
22b16ba
Merge branch 'main' into feature/bulk-email
dr-3lo Sep 29, 2025
0cd488b
post merge fix
dr-3lo Sep 29, 2025
e6a91af
Feature - Batch Email Send (#95)
dr-3lo Oct 8, 2025
82059b6
Merge branch 'main' into feature/95-batch-email
dr-3lo Oct 8, 2025
df86eae
Merge branch 'feature/95-batch-email' of https://github.com/railsware…
dr-3lo Oct 8, 2025
374bd14
post merge fix
dr-3lo Oct 8, 2025
47ce28a
Feature - Batch Email Send (#95)
dr-3lo Oct 9, 2025
31347a0
Feature - Batch Email Send (#95)
dr-3lo Oct 9, 2025
7d85d61
Feature - Batch Email Send (#95)
dr-3lo Oct 9, 2025
5978b8e
Feature - Batch Email Send (#95)
dr-3lo Oct 10, 2025
68dedc0
Feature - Batch Email Send (#95)
dr-3lo Oct 13, 2025
1c7b1ea
Feature - Batch Email Send (#95)
dr-3lo Oct 13, 2025
c5f73f6
Coderabbit comments fix
dr-3lo Oct 13, 2025
7cbeecb
Fixes for PR #158 comments:
dr-3lo Oct 14, 2025
64a6f28
Add validation tests for empty recipients in BatchEmailRequest and Se…
dr-3lo Oct 14, 2025
f31e167
using consistent assertion style.
dr-3lo Oct 14, 2025
a363f83
Refactor email request validation and documentation for clarity and c…
dr-3lo Oct 14, 2025
97038d1
Remove redundant test case for zero total recipients in "exceed" vali…
dr-3lo Oct 14, 2025
9f1dbc8
Merge branch 'main' into feature/95-batch-email
dr-3lo Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@
<PackageVersion Include="FluentAssertions" Version="7.2.0" />
<PackageVersion Include="FluentAssertions.Analyzers" Version="0.34.1" />
</ItemGroup>
</Project>
</Project>
7 changes: 7 additions & 0 deletions Mailtrap.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mailtrap.Example.ContactEve
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mailtrap.Example.EmailTemplates", "examples\Mailtrap.Example.EmailTemplates\Mailtrap.Example.EmailTemplates.csproj", "{A52169E1-8653-4B7D-9F14-84837E237E43}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Mailtrap.Example.Email.BatchSend", "examples\Mailtrap.Example.Email.BatchSend\Mailtrap.Example.Email.BatchSend.csproj", "{9922946A-03DA-4AC6-8AA6-ADEC5EF2E9EB}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -197,6 +199,10 @@ Global
{A52169E1-8653-4B7D-9F14-84837E237E43}.Debug|Any CPU.Build.0 = Debug|Any CPU
{A52169E1-8653-4B7D-9F14-84837E237E43}.Release|Any CPU.ActiveCfg = Release|Any CPU
{A52169E1-8653-4B7D-9F14-84837E237E43}.Release|Any CPU.Build.0 = Release|Any CPU
{9922946A-03DA-4AC6-8AA6-ADEC5EF2E9EB}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{9922946A-03DA-4AC6-8AA6-ADEC5EF2E9EB}.Debug|Any CPU.Build.0 = Debug|Any CPU
{9922946A-03DA-4AC6-8AA6-ADEC5EF2E9EB}.Release|Any CPU.ActiveCfg = Release|Any CPU
{9922946A-03DA-4AC6-8AA6-ADEC5EF2E9EB}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -225,6 +231,7 @@ Global
{5CEEEC08-7F1F-4F75-BC8D-6E80C54C21FD} = {09E18837-1DDE-4EAF-80EC-DA55557C81EB}
{AA91FC07-FE50-4DE1-A388-7AA0DB35C84A} = {09E18837-1DDE-4EAF-80EC-DA55557C81EB}
{A52169E1-8653-4B7D-9F14-84837E237E43} = {09E18837-1DDE-4EAF-80EC-DA55557C81EB}
{9922946A-03DA-4AC6-8AA6-ADEC5EF2E9EB} = {09E18837-1DDE-4EAF-80EC-DA55557C81EB}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {0FF614CC-FEBC-4C66-B3FC-FCB73EE511D7}
Expand Down
2 changes: 1 addition & 1 deletion build/mailtrap-global.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<PropertyGroup Label="C# Global Project Settings" Condition="'$(MSBuildProjectExtension)' == '.csproj'">
<TargetFrameworks>netstandard2.0</TargetFrameworks>
<LangVersion>12.0</LangVersion>
<LangVersion>13.0</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<IsPackable>false</IsPackable>
Expand Down
2 changes: 1 addition & 1 deletion examples/Mailtrap.Example.ApiUsage/Logic/TestSendReactor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ public TestSendReactor(IMailtrapClient mailtrapClient, ILogger<InboxReactor> log

public async Task Send(long inboxId)
{
IEmailClient emailClient = _mailtrapClient.Test(inboxId);
ISendEmailClient emailClient = _mailtrapClient.Test(inboxId);

SendEmailRequest sendEmailRequest = SendEmailRequest
.Create()
Expand Down
6 changes: 3 additions & 3 deletions examples/Mailtrap.Example.DependencyInjection/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ private static async Task Main(string[] args)
.Email() // Default client, depends on configuration
.Send(request);

IEmailClient transactionalClient = mailtrapClient.Transactional();
ISendEmailClient transactionalClient = mailtrapClient.Transactional();
response = await transactionalClient.Send(request);

IEmailClient bulkClient = mailtrapClient.Bulk();
ISendEmailClient bulkClient = mailtrapClient.Bulk();
response = await bulkClient.Send(request);

var inboxId = 1234;
IEmailClient testClient = mailtrapClient.Test(inboxId);
ISendEmailClient testClient = mailtrapClient.Test(inboxId);
response = await testClient.Send(request);
}
catch (Exception ex)
Expand Down
1 change: 1 addition & 0 deletions examples/Mailtrap.Example.Email.BatchSend/Mailtrap.Example.Email.BatchSend.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<Project Sdk="Microsoft.NET.Sdk"/>
Loading