feat(skills): add skills.create_dir to separate creation from upstream sync - #2
Merged
Merged
Conversation
…sync
By default both skills_sync (upstream bundled) and skill_manager (agent-
created) write to the same ~/.hermes/skills/. This makes it impossible
to keep upstream bundled skills and agent/user-created skills in separate
directories without inspecting .bundled_manifest.
Add skills.create_dir config key (default: empty = ~/.hermes/skills/).
When set, new skills created via skill_manage() go there instead.
This lets users configure:
skills:
create_dir: ~/personal-intelligence/hermes/skills # agent-created here
external_dirs:
- ~/personal-intelligence/hermes/bundled-skills # upstream bundled here
Also update get_all_skills_dirs() to include create_dir in the read path
so created skills are discoverable alongside bundled and external ones.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
skill_manager_tool.pyandskills_sync.pyboth write to the same~/.hermes/skills/(hardcodedSKILLS_DIR). This makes it impossible to keep upstream bundled skills and agent/user-created skills in separate directories without inspecting.bundled_manifest.Solution
Add
skills.create_dirconfig key. When set, new skills created viaskill_manage()go there instead of the default~/.hermes/skills/.Result:
bundled-skills/— upstream sync writes here (unchanged behavior)skills/— agent/user creates here (new behavior viacreate_dir)Changes
hermes_cli/config.py: addskills.create_dirschema key (default empty = backwards-compatible)tools/skill_manager_tool.py: replace hardcodedSKILLS_DIRwith_get_skills_create_dir()that reads configagent/skill_utils.py: includecreate_diringet_all_skills_dirs()read path so created skills are discoverableBackwards-compatible: empty
create_dirfalls back to~/.hermes/skills/, no behaviour change for existing installs.🤖 Generated with Claude Code