Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable django 1.7+ migrations to avoid issue #12 #13

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Christophe31
Copy link
Contributor

hoo, tests don't seems to run on the issue referenced commit…

@Christophe31
Copy link
Contributor Author

up.

@magopian
Copy link
Owner

magopian commented Jun 4, 2015

Thanks for this!

I think it's missing a few things:
1/ the south app should be removed from https://github.com/magopian/django-data-exports/blob/master/data_exports/settings.py#L11
2/ there's still a reference to a south command in the https://github.com/magopian/django-data-exports/blob/a73db486779d93046ad89c5bf582ff8ae869120f/README.rst on line 50

This is looking good, thanks for your work.

@Christophe31
Copy link
Contributor Author

South 1.0+ still works for django 1.7- …
settings and doc should differ depending on the django version…

@magopian
Copy link
Owner

magopian commented Jun 8, 2015

Are, you're right ;)

Could you please slightly amend the doc to talk about the two cases (django 1.7- and south, or django 1.8+)?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants