Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of organisasjonsnummer, with tests #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

perchrh
Copy link

@perchrh perchrh commented Jun 7, 2018

Hi,
if you want it, you can add support for organisasjonsnummer to your module.
Perhaps the name of the module should change, as well, then, to "Offentlig idnummer" / "Norwegian National ID numbers" or similar.
I needed this code myself, in order to validate both orgnr and fnr, and share the additions with you.

@codecov-io
Copy link

codecov-io commented Jun 7, 2018

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          94     94           
=====================================
  Hits           94     94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5452318...f9424d7. Read the comment docs.

@magnuswatn
Copy link
Owner

Hi!

This looks great! I will take a closer look and merge later :-) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants