Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: recovery facto whitelabeling #818

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat: recovery facto whitelabeling #818

merged 2 commits into from
Oct 18, 2024

Conversation

sukhrobbekodilov
Copy link
Contributor

@sukhrobbekodilov sukhrobbekodilov commented Oct 14, 2024 •
edited by svc-magic-git
Loading

📦 Pull Request

[Provide a general summary of the pull request here.]

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@swarmia Swarmia
Copy link

swarmia bot commented Oct 14, 2024

✅  Linked to Task PDEEXP-350 · White-label recovery factor flow
➡️  Part of Epic PDEEXP-88 · CS/Security Triaged

@sukhrobbekodilov sukhrobbekodilov force-pushed the PDEEXP-350-White-label-recovery-factor-flow branch from ecbe461 to 6e477f1 Compare October 14, 2024 12:55
hcote
hcote previously approved these changes Oct 14, 2024
View reviewed changes
Ethella
Ethella previously approved these changes Oct 16, 2024
View reviewed changes
@sukhrobbekodilov sukhrobbekodilov force-pushed the PDEEXP-350-White-label-recovery-factor-flow branch from 04b0212 to 87f76ac Compare October 17, 2024 11:51
@sukhrobbekodilov
feat: recovery facto whitelabeling
e0b2646 
fix: solving deepsource

fix: returning space

fix: fixing tests and deep source

fix: updating tests

fix: correcting a mistake

fix: updating tests

fix: adding more tests

fix: solving deepsource

feat: adding a new type and test
@sukhrobbekodilov sukhrobbekodilov force-pushed the PDEEXP-350-White-label-recovery-factor-flow branch from c07a134 to e0b2646 Compare October 17, 2024 15:08
@hcote hcote added the minor Increment the minor version when merged label Oct 17, 2024
@sukhrobbekodilov sukhrobbekodilov added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 135def7 Oct 18, 2024
6 checks passed
@sukhrobbekodilov sukhrobbekodilov deleted the PDEEXP-350-White-label-recovery-factor-flow branch October 18, 2024 15:56
@svc-magic-git
Copy link

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@svc-magic-git svc-magic-git added the released This issue/pull request has been released. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethella Ethella Ethella approved these changes

@hcote hcote hcote approved these changes

@khamdam-magic khamdam-magic Awaiting requested review from khamdam-magic

Assignees
No one assigned
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sukhrobbekodilov @svc-magic-git @Ethella @hcote