Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change display css to visibility #772

Merged
merged 4 commits into from
Aug 9, 2024
Merged

change display css to visibility #772

merged 4 commits into from
Aug 9, 2024

Conversation

hcote
Copy link
Contributor

@hcote hcote commented Aug 1, 2024 •
edited by svc-magic-git
Loading

📦 Pull Request

[Provide a general summary of the pull request here.]

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@hcote hcote added the patch Increment the patch version when merged label Aug 8, 2024
@Ethella
Copy link
Member

Ethella commented Aug 8, 2024

Does it have an impact to our performance?

@hcote hcote added this pull request to the merge queue Aug 9, 2024
Merged via the queue into master with commit a573e0d Aug 9, 2024
6 checks passed
@hcote hcote deleted the hcote-visibility-update branch August 9, 2024 15:56
@svc-magic-git
Copy link

🚀 PR was released in @magic-sdk/[email protected], [email protected] 🚀

@svc-magic-git svc-magic-git added the released This issue/pull request has been released. label Aug 9, 2024
@johanneskares johanneskares mentioned this pull request Sep 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trystendsmyth trystendsmyth trystendsmyth approved these changes

@Ethella Ethella Ethella approved these changes

@bcleary06 bcleary06 Awaiting requested review from bcleary06

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hcote @Ethella @svc-magic-git @trystendsmyth