Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: consider the provider ready after 15s even if the message hasn't arrived #760

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix: consider the provider ready after 15s even if the message hasn't arrived #760

merged 1 commit into from
Jul 11, 2024

Conversation

romin-halltari
Copy link
Contributor

@romin-halltari romin-halltari commented Jul 11, 2024 •
edited by svc-magic-git
Loading

📦 Pull Request

We expect the overlay to be ready within 15 seconds. Sometimes the message is not properly processed due to webview issues. In that case, after 15 seconds we consider the overlay ready, to avoid requests hanging forever.

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@romin-halltari romin-halltari added the minor Increment the minor version when merged label Jul 11, 2024
@romin-halltari romin-halltari self-assigned this Jul 11, 2024
@romin-halltari romin-halltari force-pushed the rh-set-timeout-for-ready branch from f6b31c3 to b91a0e0 Compare July 11, 2024 20:25
@romin-halltari romin-halltari requested a review from Ethella July 11, 2024 20:30
@romin-halltari romin-halltari added this pull request to the merge queue Jul 11, 2024
Merged via the queue into master with commit d3c4840 Jul 11, 2024
5 of 6 checks passed
@romin-halltari romin-halltari deleted the rh-set-timeout-for-ready branch July 11, 2024 21:07
@svc-magic-git
Copy link

🚀 PR was released in @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-ext/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@svc-magic-git svc-magic-git added the released This issue/pull request has been released. label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethella Ethella Ethella approved these changes

@joshuascan joshuascan joshuascan approved these changes

Assignees

@romin-halltari romin-halltari

Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romin-halltari @svc-magic-git @Ethella @joshuascan