Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn developers of Coming Deprecation of Universal Wallet API Keys #716

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

Ariflo
Copy link
Contributor

@Ariflo Ariflo commented Feb 23, 2024

📦 Pull Request

Adds warning to Universal Wallet API Key app developers of impending doom 😈 of Universal Wallet API Keys. We check for product_type to be returned via postMessage after the initial call to /config when we retrieve the theme.

When utilizing a UW API Keys the warning will appear as follows for magic-sdk and all react-native SDK apps:

WARN  Magic SDK Warning: [DEPRECATION_NOTICE] `Usage of Universal Wallet API Keys` will be removed from `@magic-sdk/react-native-bare` in version `v22.0.0`. Use `Dedicated Wallet API Key` instead to prevent disruption of the wallet service.

✅ Fixed Issues

N/A

🚨 Test instructions

Run https://github.com/magiclabs/react-native-demo app locally and follow the instructions set here to test.

Reviewer Notes (Optional)

This PR will work in tandem with https://github.com/magiclabs/phantom/pull/3360

⚠️ Don't forget to add a semver label!

Please only add one label:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-ext/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install @magic-sdk/[email protected]
npm install [email protected]
# or 
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-ext/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add @magic-sdk/[email protected]
yarn add [email protected]

@Ariflo Ariflo self-assigned this Feb 23, 2024
@Ariflo Ariflo added the minor Increment the minor version when merged label Feb 23, 2024
@Ariflo Ariflo added this pull request to the merge queue Feb 26, 2024
Merged via the queue into master with commit 07eb61b Feb 26, 2024
4 checks passed
@Ariflo Ariflo deleted the ariflo-PDEEXP-237-warn-universal-wallet-devs-of-doom-2 branch February 26, 2024 18:03
@Ariflo Ariflo added the released This issue/pull request has been released. label Feb 26, 2024
@magiclabs magiclabs deleted a comment from Ariflo Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants